Reject unrepresentable pointer types in intrinsics. Fixes PR7316.
authorNick Lewycky <nicholas@mxc.ca>
Sun, 8 Aug 2010 06:12:09 +0000 (06:12 +0000)
committerNick Lewycky <nicholas@mxc.ca>
Sun, 8 Aug 2010 06:12:09 +0000 (06:12 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@110541 91177308-0d34-0410-b5e6-96231b3b80d8

lib/VMCore/Verifier.cpp
test/Verifier/2010-08-07-PointerIntrinsic.ll [new file with mode: 0644]

index 52fd134d488d3ba6cad86c14b7ef492557d08d37..fe4e674532fe69a434f0c35f2e23d9cdaf4fb554 100644 (file)
@@ -1840,8 +1840,13 @@ bool Verifier::PerformTypeCheck(Intrinsic::ID ID, Function *F, const Type *Ty,
     // and iPTR. In the verifier, we can not distinguish which case we have so
     // allow either case to be legal.
     if (const PointerType* PTyp = dyn_cast<PointerType>(Ty)) {
-      Suffix += ".p" + utostr(PTyp->getAddressSpace()) + 
-        EVT::getEVT(PTyp->getElementType()).getEVTString();
+      EVT PointeeVT = EVT::getEVT(PTyp->getElementType(), true);
+      if (PointeeVT == MVT::Other) {
+        CheckFailed("Intrinsic has pointer to complex type.");
+        return false;
+      }
+      Suffix += ".p" + utostr(PTyp->getAddressSpace()) +
+        PointeeVT.getEVTString();
     } else {
       CheckFailed(IntrinsicParam(ArgNo, NumRetVals) + " is not a "
                   "pointer and a pointer is required.", F);
diff --git a/test/Verifier/2010-08-07-PointerIntrinsic.ll b/test/Verifier/2010-08-07-PointerIntrinsic.ll
new file mode 100644 (file)
index 0000000..bf5563d
--- /dev/null
@@ -0,0 +1,21 @@
+; RUN: not llvm-as < %s 2> %t
+; RUN: grep {Broken module} %t
+; PR7316
+
+target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:32"
+target triple = "x86-unknown-unknown"
+@aa = global [32 x i8] zeroinitializer, align 1
+@bb = global [16 x i8] zeroinitializer, align 1
+define void @x() nounwind {
+L.0:
+       %0 = getelementptr [32 x i8]* @aa, i32 0, i32 4
+       %1 = bitcast i8* %0 to [16 x i8]*
+       %2 = bitcast [16 x i8]* %1 to [0 x i8]*
+       %3 = getelementptr [16 x i8]* @bb
+       %4 = bitcast [16 x i8]* %3 to [0 x i8]*
+       call void @llvm.memcpy.i32([0 x i8]* %2, [0 x i8]* %4, i32 16, i32 1)
+       br label %return
+return:
+       ret void
+}
+declare void @llvm.memcpy.i32([0 x i8]*, [0 x i8]*, i32, i32) nounwind