fix include dependencies in folly/stats
authorSven Over <over@fb.com>
Sun, 25 Dec 2016 08:40:42 +0000 (00:40 -0800)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Sun, 25 Dec 2016 08:47:54 +0000 (00:47 -0800)
Summary:
Histogram-defs.h depends on Histogram.h, so it should include it.

This missing dependency is especially annoying because users who
include both Histogram.h and Histogram-defs.h will find that
clang-format reorders the includes such that Histogram-defs.h will
be included before Histogram.h, which breaks the build.

Same for BucketedTimeSeries-defs.h and TimeseriesHistogram-defs.h.

Reviewed By: pixelb

Differential Revision: D4366282

fbshipit-source-id: 518ef315154c28beb091e5c097db2bec6eea3ba0

folly/stats/BucketedTimeSeries-defs.h
folly/stats/Histogram-defs.h
folly/stats/TimeseriesHistogram-defs.h

index bd38f6d5c8e6cb24043672945e5fa17f6dd437aa..c21cb5dcb0001901e2b20968a15dd059ea6e5da6 100644 (file)
@@ -19,6 +19,7 @@
 #include <algorithm>
 #include <glog/logging.h>
 #include <folly/Likely.h>
+#include <folly/stats/BucketedTimeSeries.h>
 
 namespace folly {
 
index 5cc62f8968183d92264fcdf8edf66980d00133ce..f89bdf118eeac9f29d04d7ee16d77cdf72217e57 100644 (file)
@@ -17,6 +17,7 @@
 #pragma once
 
 #include <folly/Conv.h>
+#include <folly/stats/Histogram.h>
 
 #include <glog/logging.h>
 
index 08c44e967b38f00b1484cc7c3e1e34100d27432f..509273f6b4b3b7ffd7893c48239c6ec61711a8a3 100644 (file)
 #pragma once
 
 #include <folly/Conv.h>
+#include <folly/stats/BucketedTimeSeries-defs.h>
 #include <folly/stats/Histogram-defs.h>
 #include <folly/stats/MultiLevelTimeSeries-defs.h>
-#include <folly/stats/BucketedTimeSeries-defs.h>
+#include <folly/stats/TimeseriesHistogram.h>
 
 namespace folly {