finish promise support
authorBrian Demsky <bdemsky@uci.edu>
Fri, 27 Jul 2012 05:20:54 +0000 (22:20 -0700)
committerBrian Norris <banorris@uci.edu>
Thu, 2 Aug 2012 17:12:52 +0000 (10:12 -0700)
model.cc
model.h
promise.h

index de5687317c7e794f1a2dfa9bf99d01bb303e4036..d8699b0ebfe850b3a0a8d3d277f3ca914db0b59f 100644 (file)
--- a/model.cc
+++ b/model.cc
@@ -133,7 +133,11 @@ thread_id_t ModelChecker::get_next_replay_thread()
        if (next == diverge) {
                Node *nextnode = next->get_node();
                /* Reached divergence point */
-               if (nextnode->increment_read_from()) {
+               if (nextnode->increment_promises()) {
+                       /* The next node will try to satisfy a different set of promises. */
+                       tid = next->get_tid();
+                       node_stack->pop_restofstack(2);
+               } else if (nextnode->increment_read_from()) {
                        /* The next node will read from a different value. */
                        tid = next->get_tid();
                        node_stack->pop_restofstack(2);
@@ -286,6 +290,8 @@ void ModelChecker::check_current_action(void)
                        /* Build may_read_from set */
                        if (curr->is_read())
                                build_reads_from_past(curr);
+                       if (curr->is_write())
+                               compute_promises(curr);
                }
        }
 
@@ -342,7 +348,7 @@ void ModelChecker::check_current_action(void)
        Node *currnode = curr->get_node();
        Node *parnode = currnode->get_parent();
 
-       if (!parnode->backtrack_empty()||!currnode->readsfrom_empty()||!currnode->futurevalues_empty())
+       if (!parnode->backtrack_empty()||!currnode->readsfrom_empty()||!currnode->futurevalues_empty()||!currnode->promises_empty())
                if (!next_backtrack || *curr > *next_backtrack)
                        next_backtrack = curr;
        
@@ -518,7 +524,18 @@ ClockVector * ModelChecker::get_cv(thread_id_t tid) {
 
 /** Resolve promises. */
 
-void ModelChecker::resolve_promises(ModelAction *curr) {
+void ModelChecker::resolve_promises(ModelAction *write) {
+       for(unsigned int i=0;i<promises->size();i++) {
+               Promise * promise=(*promises)[i];
+               if (write->get_node()->get_promise(i)) {
+                       ModelAction * read=promise->get_action();
+                       read->read_from(write);
+                       r_modification_order(read, write);
+               }
+       }
+}
+
+void ModelChecker::compute_promises(ModelAction *curr) {
        for(unsigned int i=0;i<promises->size();i++) {
                Promise * promise=(*promises)[i];
                const ModelAction * act=promise->get_action();
@@ -527,8 +544,7 @@ void ModelChecker::resolve_promises(ModelAction *curr) {
                                !act->is_synchronizing(curr)&&
                                !act->same_thread(curr)&&
                                promise->get_value()==curr->get_value()) {
-                       
-                       
+                       curr->get_node()->set_promise(i);
                }
        }
 }
diff --git a/model.h b/model.h
index 3c225559606224878ce5c84497242f29604dda23..574ed21a041f934c411992b9aa73f94d624b06a6 100644 (file)
--- a/model.h
+++ b/model.h
@@ -79,6 +79,7 @@ private:
        ModelAction * get_next_backtrack();
        void reset_to_initial_state();
        void resolve_promises(ModelAction *curr);
+       void compute_promises(ModelAction *curr);
 
        void add_action_to_lists(ModelAction *act);
        ModelAction * get_last_action(thread_id_t tid);
index 0bf62d6b6a6bb1358383cd772ac0c5c9cd6d04a0..7b3d1ecf363baf36e7cda4b2ae3d034a80ad61cf 100644 (file)
--- a/promise.h
+++ b/promise.h
@@ -14,7 +14,7 @@ class ModelAction;
 class Promise {
  public:
        Promise(ModelAction * act, uint64_t value);
-       const ModelAction * get_action() { return read; }
+       ModelAction * get_action() { return read; }
        int increment_threads() { return ++numthreads; }
        uint64_t get_value() { return value; }