Simplify code. No intended functionality change.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@84790 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/VMCore/Metadata.cpp b/lib/VMCore/Metadata.cpp
index ce5cc7eed148517bca6e6a46c8bacfc3ba229ffc..422a21545adb3b3852e7198baee8fac5531f1d9f 100644 (file)
--- a/lib/VMCore/Metadata.cpp
+++ b/lib/VMCore/Metadata.cpp
@@ -259,23 +259,17 @@ unsigned MetadataContext::registerMDKind(const StringRef Name) {
 
 /// isValidName - Return true if Name is a valid custom metadata handler name.
 bool MetadataContext::isValidName(const StringRef MDName) {
-  const char *Name = MDName.data();
-  if (!Name)
+  if (MDName.empty())
     return false;
 
-  if (!isalpha(*Name))
+  if (!isalpha(MDName[1]))
     return false;
 
-  unsigned Length = strlen(Name);  
-  unsigned Count = 1;
-  ++Name;
-  while (Name &&
-         (isalnum(*Name) || *Name == '_' || *Name == '-' || *Name == '.')) {
-    ++Name;
-    ++Count;
+  for (StringRef::iterator I = MDName.begin() + 1, E = MDName.end(); I != E;
+       ++I) {
+    if (!isalnum(*I) && *I != '_' && *I != '-' && *I != '.')
+        return false;
   }
-  if (Length != Count)
-    return false;
   return true;
 }