These two conditions are not exclusive!!

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@8518 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Analysis/IPA/CallGraph.cpp b/lib/Analysis/IPA/CallGraph.cpp
index 980d11961e7d4b70b5875fc742da0e91a2b953b4..d5cbe3d02b43d10d5b7e0fce3276a51987e32936 100644 (file)
--- a/lib/Analysis/IPA/CallGraph.cpp
+++ b/lib/Analysis/IPA/CallGraph.cpp
@@ -64,7 +64,7 @@ CallGraphNode *CallGraph::getNodeFor(Function *F) {
 void CallGraph::addToCallGraph(Function *F) {
   CallGraphNode *Node = getNodeFor(F);
 
-  // If this function has external linkage, 
+  // If this function has external linkage, anything could call it...
   if (!F->hasInternalLinkage()) {
     ExternalNode->addCalledFunction(Node);
 
@@ -75,9 +75,12 @@ void CallGraph::addToCallGraph(Function *F) {
       else
         Root = Node;          // Found a main, keep track of it!
     }
-  } else if (F->isExternal()) { // Not defined in this xlation unit?
-    Node->addCalledFunction(ExternalNode);  // It could call anything...
   }
+  
+  // If this function is not defined in this translation unit, it could call
+  // anything.
+  if (F->isExternal())
+    Node->addCalledFunction(ExternalNode);
 
   // Loop over all of the users of the function... looking for callers...
   //