MC/Mach-O: Fix a crash on invalid.
authorDaniel Dunbar <daniel@zuster.org>
Tue, 11 May 2010 23:53:05 +0000 (23:53 +0000)
committerDaniel Dunbar <daniel@zuster.org>
Tue, 11 May 2010 23:53:05 +0000 (23:53 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@103525 91177308-0d34-0410-b5e6-96231b3b80d8

lib/MC/MachObjectWriter.cpp

index c45fbd5dad0c2699faa38dfe38221d073c7ea857..0b005838c6ace72233a38ce25e0b6ae970fa30d3 100644 (file)
@@ -584,7 +584,7 @@ public:
         // Add the local offset, if needed.
         if (Base != &SD)
           Value += Layout.getSymbolAddress(&SD) - Layout.getSymbolAddress(Base);
-      } else {
+      } else if (Symbol->isInSection()) {
         // The index is the section ordinal (1-based).
         Index = SD.getFragment()->getParent()->getOrdinal() + 1;
         IsExtern = 0;
@@ -592,6 +592,9 @@ public:
 
         if (IsPCRel)
           Value -= Address + (1 << Log2Size);
+      } else {
+        report_fatal_error("unsupported relocation of undefined symbol '" +
+                           Symbol->getName() + "'");
       }
 
       MCSymbolRefExpr::VariantKind Modifier = Target.getSymA()->getKind();