Object: Small cleanup in COFFObjectFile::getSymbol
authorDavid Majnemer <david.majnemer@gmail.com>
Thu, 11 Sep 2014 23:42:10 +0000 (23:42 +0000)
committerDavid Majnemer <david.majnemer@gmail.com>
Thu, 11 Sep 2014 23:42:10 +0000 (23:42 +0000)
NFC.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217648 91177308-0d34-0410-b5e6-96231b3b80d8

include/llvm/Object/COFF.h

index ae79f8b608d0adfbe26f252d4bed477e91454b14..87e8cc2dfabcf43db0fe29aeb089217ad6775a64 100644 (file)
@@ -569,10 +569,10 @@ public:
   template <typename coff_symbol_type>
   std::error_code getSymbol(uint32_t Index,
                             const coff_symbol_type *&Res) const {
-    if (Index < getNumberOfSymbols())
-      Res = reinterpret_cast<coff_symbol_type *>(getSymbolTable()) + Index;
-    else
+    if (Index >= getNumberOfSymbols())
       return object_error::parse_failed;
+
+    Res = reinterpret_cast<coff_symbol_type *>(getSymbolTable()) + Index;
     return object_error::success;
   }
   ErrorOr<COFFSymbolRef> getSymbol(uint32_t index) const {