IR: Store MDNodes in a separate LeakDetector container

This gives us better leak detection messages, like `Value` has.

This also has the side effect of papering over a problem where
`MachineInstr`s are added as garbage to the leak detector and then
deleted without being removed.  If `MDNode::getTemporary()` allocates an
`MDNodeFwdDecl` in the same spot, the leak detector asserts.  By
separating `MDNode`s into their own container we lose that assertion.

Since `MachineInstr` is required to have a trivial destructor, its usage
of `LeakDetector` at all is pretty suspect.  I'll be sending a patch
soon to strip that out.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@224060 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/llvm/IR/LeakDetector.h b/include/llvm/IR/LeakDetector.h
index fb3202e902a16356cbf536f40697349e1d2487b5..b014fe081f003ad3a113defdba2099deaa884030 100644 (file)
--- a/include/llvm/IR/LeakDetector.h
+++ b/include/llvm/IR/LeakDetector.h
@@ -28,6 +28,7 @@ namespace llvm {
 
 class LLVMContext;
 class Value;
 
 class LLVMContext;
 class Value;

+class MDNode;

 
 struct LeakDetector {
   /// addGarbageObject - Add a pointer to the internal set of "garbage" object
 
 struct LeakDetector {
   /// addGarbageObject - Add a pointer to the internal set of "garbage" object


@@ -72,6 +73,18 @@ private:
   static void addGarbageObjectImpl(const Value *Object);
   static void removeGarbageObjectImpl(const Value *Object);
 
   static void addGarbageObjectImpl(const Value *Object);
   static void removeGarbageObjectImpl(const Value *Object);
 

+  /// Overload the normal methods to work better with MDNode* to improve error
+  /// messages.
+  ///
+  /// For better or worse, this hides errors when other types are added as
+  /// garbage, deleted without being removed, and an MDNode is allocated in the
+  /// same spot.
+  ///
+  /// \note Only handle \a MDNode for now, since we can't always get access to
+  /// an \a LLVMContext for other \a Metadata types.
+  static void addGarbageObjectImpl(const MDNode *Object);
+  static void removeGarbageObjectImpl(const MDNode *Object);
+

   static void addGarbageObjectImpl(void *Object);
   static void removeGarbageObjectImpl(void *Object);
   static void checkForGarbageImpl(LLVMContext &C, const std::string &Message);
   static void addGarbageObjectImpl(void *Object);
   static void removeGarbageObjectImpl(void *Object);
   static void checkForGarbageImpl(LLVMContext &C, const std::string &Message);

diff --git a/lib/IR/LeakDetector.cpp b/lib/IR/LeakDetector.cpp
index 6f71627fcf994cc3ba3607cc83daedb6dd842c53..be07a481883f81a52d98f9d64f17f5bf4f9cfae6 100644 (file)
--- a/lib/IR/LeakDetector.cpp
+++ b/lib/IR/LeakDetector.cpp
@@ -14,6 +14,7 @@
 #include "llvm/IR/LeakDetector.h"
 #include "LLVMContextImpl.h"
 #include "llvm/ADT/SmallPtrSet.h"
 #include "llvm/IR/LeakDetector.h"
 #include "LLVMContextImpl.h"
 #include "llvm/ADT/SmallPtrSet.h"

+#include "llvm/IR/Metadata.h"

 #include "llvm/IR/Value.h"
 #include "llvm/Support/Compiler.h"
 #include "llvm/Support/ManagedStatic.h"
 #include "llvm/IR/Value.h"
 #include "llvm/Support/Compiler.h"
 #include "llvm/Support/ManagedStatic.h"


@@ -39,6 +40,11 @@ void LeakDetector::addGarbageObjectImpl(const Value *Object) {
   pImpl->LLVMObjects.addGarbage(Object);
 }
 
   pImpl->LLVMObjects.addGarbage(Object);
 }
 

+void LeakDetector::addGarbageObjectImpl(const MDNode *Object) {
+  LLVMContextImpl *pImpl = Object->getContext().pImpl;
+  pImpl->LLVMMDObjects.addGarbage(Object);
+}
+

 void LeakDetector::removeGarbageObjectImpl(void *Object) {
   sys::SmartScopedLock<true> Lock(*ObjectsLock);
   Objects->removeGarbage(Object);
 void LeakDetector::removeGarbageObjectImpl(void *Object) {
   sys::SmartScopedLock<true> Lock(*ObjectsLock);
   Objects->removeGarbage(Object);


@@ -49,6 +55,11 @@ void LeakDetector::removeGarbageObjectImpl(const Value *Object) {
   pImpl->LLVMObjects.removeGarbage(Object);
 }
 
   pImpl->LLVMObjects.removeGarbage(Object);
 }
 

+void LeakDetector::removeGarbageObjectImpl(const MDNode *Object) {
+  LLVMContextImpl *pImpl = Object->getContext().pImpl;
+  pImpl->LLVMMDObjects.removeGarbage(Object);
+}
+

 void LeakDetector::checkForGarbageImpl(LLVMContext &Context, 
                                        const std::string &Message) {
   LLVMContextImpl *pImpl = Context.pImpl;
 void LeakDetector::checkForGarbageImpl(LLVMContext &Context, 
                                        const std::string &Message) {
   LLVMContextImpl *pImpl = Context.pImpl;


@@ -56,10 +67,12 @@ void LeakDetector::checkForGarbageImpl(LLVMContext &Context,
   
   Objects->setName("GENERIC");
   pImpl->LLVMObjects.setName("LLVM");
   
   Objects->setName("GENERIC");
   pImpl->LLVMObjects.setName("LLVM");

+  pImpl->LLVMMDObjects.setName("LLVM-MD");

   
   // use non-short-circuit version so that both checks are performed
   if (Objects->hasGarbage(Message) |
   
   // use non-short-circuit version so that both checks are performed
   if (Objects->hasGarbage(Message) |

-      pImpl->LLVMObjects.hasGarbage(Message))
+      pImpl->LLVMObjects.hasGarbage(Message) |
+      pImpl->LLVMMDObjects.hasGarbage(Message))

     errs() << "\nThis is probably because you removed an object, but didn't "
            << "delete it.  Please check your code for memory leaks.\n";
 
     errs() << "\nThis is probably because you removed an object, but didn't "
            << "delete it.  Please check your code for memory leaks.\n";
 

diff --git a/lib/IR/LeaksContext.h b/lib/IR/LeaksContext.h
index 3e485abdfd18056f370b0ba5f825570fb3bf6e74..47704fa1a76203a11548b1338379e12d9339c881 100644 (file)
--- a/lib/IR/LeaksContext.h
+++ b/lib/IR/LeaksContext.h
@@ -16,6 +16,7 @@
 #define LLVM_LIB_IR_LEAKSCONTEXT_H
 
 #include "llvm/ADT/SmallPtrSet.h"
 #define LLVM_LIB_IR_LEAKSCONTEXT_H
 
 #include "llvm/ADT/SmallPtrSet.h"

+#include "llvm/IR/Metadata.h"

 #include "llvm/IR/Value.h"
 #include "llvm/Support/raw_ostream.h"
 
 #include "llvm/IR/Value.h"
 #include "llvm/Support/raw_ostream.h"
 


@@ -31,6 +32,10 @@ struct PrinterTrait<Value> {
   static void print(const Value* P) { errs() << *P; }
 };
 
   static void print(const Value* P) { errs() << *P; }
 };
 

+template <> struct PrinterTrait<Metadata> {
+  static void print(const Metadata *P) { P->print(errs()); }
+};
+

 template <typename T>
 struct LeakDetectorImpl {
   explicit LeakDetectorImpl(const char* const name = "") : 
 template <typename T>
 struct LeakDetectorImpl {
   explicit LeakDetectorImpl(const char* const name = "") :