Changed XXX to FIXME, and added comment to the README file

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43359 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/CodeGen/BranchFolding.cpp b/lib/CodeGen/BranchFolding.cpp
index 021001d15fc0b65edc9260e758dab5cbb882f4b9..d4b1e90fd54c8f530ba483edca7c8265f69a3800 100644 (file)
--- a/lib/CodeGen/BranchFolding.cpp
+++ b/lib/CodeGen/BranchFolding.cpp
@@ -272,7 +272,7 @@ static unsigned ComputeCommonTailLength(MachineBasicBlock *MBB1,
   while (I1 != MBB1->begin() && I2 != MBB2->begin()) {
     --I1; --I2;
     if (!I1->isIdenticalTo(I2) || 
-        // XXX: This check is dubious. It's used to get around a problem where
+        // FIXME: This check is dubious. It's used to get around a problem where
         // people incorrectly expect inline asm directives to remain in the same
         // relative order. This is untenable because normal compiler
         // optimizations (like this one) may reorder and/or merge these

diff --git a/lib/CodeGen/README.txt b/lib/CodeGen/README.txt
index 1e2837580ac90a19460b0bd2cad8a34200e38c0d..fc59cdf86401aa89298136b82892c1ca8fa00814 100644 (file)
--- a/lib/CodeGen/README.txt
+++ b/lib/CodeGen/README.txt
@@ -179,3 +179,11 @@ work.
 
 The ocaml frametable structure supports liveness information. It would be good
 to support it.
+
+//===---------------------------------------------------------------------===//
+
+The FIXME in ComputeCommonTailLength in BranchFolding.cpp needs to be
+revisited. The check is there to work around a misuse of directives in inline
+assembly.
+
+//===---------------------------------------------------------------------===//