MC: Fix associative sections on COFF

COFF sections in MC were represented by a tuple of section-name and
COMDAT-name.  This is not sufficient to represent a .text section
associated with another .text section; we need a way to distinguish
between the key section and the one marked associative.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@211913 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/llvm/MC/MCContext.h b/include/llvm/MC/MCContext.h
index ce3a99bb3fe12ff1101baede5acd4db1ce4844bd..eb0340f7421a322bd3b45da5612b6b9db14e4f76 100644 (file)
--- a/include/llvm/MC/MCContext.h
+++ b/include/llvm/MC/MCContext.h
@@ -22,6 +22,7 @@
 #include "llvm/Support/Compiler.h"
 #include "llvm/Support/raw_ostream.h"
 #include <map>
 #include "llvm/Support/Compiler.h"
 #include "llvm/Support/raw_ostream.h"
 #include <map>

+#include <tuple>

 #include <vector> // FIXME: Shouldn't be needed.
 
 namespace llvm {
 #include <vector> // FIXME: Shouldn't be needed.
 
 namespace llvm {


@@ -160,10 +161,11 @@ namespace llvm {
     unsigned DwarfCompileUnitID;
 
     typedef std::pair<std::string, std::string> SectionGroupPair;
     unsigned DwarfCompileUnitID;
 
     typedef std::pair<std::string, std::string> SectionGroupPair;

+    typedef std::tuple<std::string, std::string, int> SectionGroupTriple;

 
     StringMap<const MCSectionMachO*> MachOUniquingMap;
     std::map<SectionGroupPair, const MCSectionELF *> ELFUniquingMap;
 
     StringMap<const MCSectionMachO*> MachOUniquingMap;
     std::map<SectionGroupPair, const MCSectionELF *> ELFUniquingMap;

-    std::map<SectionGroupPair, const MCSectionCOFF *> COFFUniquingMap;
+    std::map<SectionGroupTriple, const MCSectionCOFF *> COFFUniquingMap;

 
     /// Do automatic reset in destructor
     bool AutoReset;
 
     /// Do automatic reset in destructor
     bool AutoReset;

diff --git a/lib/MC/MCContext.cpp b/lib/MC/MCContext.cpp
index bd2c4e960ac475b56139617c87ba2db0f615b69f..cfdab0cba8bc28786dd799882375675343328292 100644 (file)
--- a/lib/MC/MCContext.cpp
+++ b/lib/MC/MCContext.cpp
@@ -284,8 +284,8 @@ const MCSectionCOFF *MCContext::getCOFFSection(StringRef Section,
                                                int Selection) {
   // Do the lookup, if we have a hit, return it.
 
                                                int Selection) {
   // Do the lookup, if we have a hit, return it.
 

-  SectionGroupPair P(Section, COMDATSymName);
-  auto IterBool = COFFUniquingMap.insert(std::make_pair(P, nullptr));
+  SectionGroupTriple T(Section, COMDATSymName, Selection);
+  auto IterBool = COFFUniquingMap.insert(std::make_pair(T, nullptr));

   auto Iter = IterBool.first;
   if (!IterBool.second)
     return Iter->second;
   auto Iter = IterBool.first;
   if (!IterBool.second)
     return Iter->second;


@@ -294,7 +294,7 @@ const MCSectionCOFF *MCContext::getCOFFSection(StringRef Section,
   if (!COMDATSymName.empty())
     COMDATSymbol = GetOrCreateSymbol(COMDATSymName);
 
   if (!COMDATSymName.empty())
     COMDATSymbol = GetOrCreateSymbol(COMDATSymName);
 

-  StringRef CachedName = Iter->first.first;
+  StringRef CachedName = std::get<0>(Iter->first);

   MCSectionCOFF *Result = new (*this)
       MCSectionCOFF(CachedName, Characteristics, COMDATSymbol, Selection, Kind);
 
   MCSectionCOFF *Result = new (*this)
       MCSectionCOFF(CachedName, Characteristics, COMDATSymbol, Selection, Kind);
 


@@ -309,8 +309,8 @@ MCContext::getCOFFSection(StringRef Section, unsigned Characteristics,
 }
 
 const MCSectionCOFF *MCContext::getCOFFSection(StringRef Section) {
 }
 
 const MCSectionCOFF *MCContext::getCOFFSection(StringRef Section) {

-  SectionGroupPair P(Section, "");
-  auto Iter = COFFUniquingMap.find(P);
+  SectionGroupTriple T(Section, "", 0);
+  auto Iter = COFFUniquingMap.find(T);

   if (Iter == COFFUniquingMap.end())
     return nullptr;
   return Iter->second;
   if (Iter == COFFUniquingMap.end())
     return nullptr;
   return Iter->second;

diff --git a/lib/MC/MCParser/COFFAsmParser.cpp b/lib/MC/MCParser/COFFAsmParser.cpp
index 0d914efe8748b1bf453eea378ad346469cb20409..146889599e03f5019e03463542b6d9e1d628d7d0 100644 (file)
--- a/lib/MC/MCParser/COFFAsmParser.cpp
+++ b/lib/MC/MCParser/COFFAsmParser.cpp
@@ -292,8 +292,7 @@ bool COFFAsmParser::ParseDirectiveSymbolAttribute(StringRef Directive, SMLoc) {
 bool COFFAsmParser::ParseSectionSwitch(StringRef Section,
                                        unsigned Characteristics,
                                        SectionKind Kind) {
 bool COFFAsmParser::ParseSectionSwitch(StringRef Section,
                                        unsigned Characteristics,
                                        SectionKind Kind) {

-  return ParseSectionSwitch(Section, Characteristics, Kind, "",
-                            COFF::IMAGE_COMDAT_SELECT_ANY);
+  return ParseSectionSwitch(Section, Characteristics, Kind, "", (COFF::COMDATType)0);

 }
 
 bool COFFAsmParser::ParseSectionSwitch(StringRef Section,
 }
 
 bool COFFAsmParser::ParseSectionSwitch(StringRef Section,


@@ -357,9 +356,10 @@ bool COFFAsmParser::ParseDirectiveSection(StringRef, SMLoc) {
       return true;
   }
 
       return true;
   }
 

-  COFF::COMDATType Type = COFF::IMAGE_COMDAT_SELECT_ANY;
+  COFF::COMDATType Type = (COFF::COMDATType)0;

   StringRef COMDATSymName;
   if (getLexer().is(AsmToken::Comma)) {
   StringRef COMDATSymName;
   if (getLexer().is(AsmToken::Comma)) {

+    Type = COFF::IMAGE_COMDAT_SELECT_ANY;;

     Lex();
 
     Flags |= COFF::IMAGE_SCN_LNK_COMDAT;
     Lex();
 
     Flags |= COFF::IMAGE_SCN_LNK_COMDAT;

diff --git a/test/MC/COFF/section-comdat.s b/test/MC/COFF/section-comdat.s
index 8a7de1a1d9192a5b303bfcfea55bc1642d49a6a4..e7052d8f5ae3f98fd4285205c21076ad428d6be4 100644 (file)
--- a/test/MC/COFF/section-comdat.s
+++ b/test/MC/COFF/section-comdat.s
@@ -39,6 +39,11 @@ Symbol6:
 Symbol7:
 .long 1
 
 Symbol7:
 .long 1
 

+.section assocSec, "dr", associative, "assocSym"
+.globl Symbol8
+Symbol8:
+.long 1
+

 // CHECK: Sections [
 // CHECK:   Section {
 // CHECK:     Number: 4
 // CHECK: Sections [
 // CHECK:   Section {
 // CHECK:     Number: 4


@@ -185,7 +190,19 @@ Symbol7:
 // CHECK:     Section: SecName (11)
 // CHECK:   }
 // CHECK:   Symbol {
 // CHECK:     Section: SecName (11)
 // CHECK:   }
 // CHECK:   Symbol {

+// CHECK:     Name: assocSec
+// CHECK:     Section: assocSec (12)
+// CHECK:     AuxSectionDef {
+// CHECK:       Selection: Associative (0x5)
+// CHECK:       AssocSection: assocSec (4)
+// CHECK:     }
+// CHECK:   }
+// CHECK:   Symbol {

 // CHECK:     Name: Symbol5
 // CHECK:     Section: SecName (9)
 // CHECK:   }
 // CHECK:     Name: Symbol5
 // CHECK:     Section: SecName (9)
 // CHECK:   }

+// CHECK:   Symbol {
+// CHECK:     Name: Symbol8
+// CHECK:     Section: assocSec (12)
+// CHECK:   }

 // CHECK: ]
 // CHECK: ]