Use an early return. NFC.
authorRafael Espindola <rafael.espindola@gmail.com>
Mon, 11 Aug 2014 16:55:42 +0000 (16:55 +0000)
committerRafael Espindola <rafael.espindola@gmail.com>
Mon, 11 Aug 2014 16:55:42 +0000 (16:55 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@215363 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Linker/LinkModules.cpp

index 5bb2862cca08cd61511aa3422547ce9c9e10102e..1f4c3c13238e770d6904987ea16a72266a4d47dd 100644 (file)
@@ -647,14 +647,15 @@ bool ModuleLinker::getComdatResult(const Comdat *SrcC,
   StringRef ComdatName = SrcC->getName();
   Module::ComdatSymTabType &ComdatSymTab = DstM->getComdatSymbolTable();
   Module::ComdatSymTabType::iterator DstCI = ComdatSymTab.find(ComdatName);
-  if (DstCI != ComdatSymTab.end()) {
-    const Comdat *DstC = &DstCI->second;
-    Comdat::SelectionKind SSK = SrcC->getSelectionKind();
-    Comdat::SelectionKind DSK = DstC->getSelectionKind();
-    if (computeResultingSelectionKind(ComdatName, SSK, DSK, Result, LinkFromSrc))
-      return true;
-  }
-  return false;
+
+  if (DstCI == ComdatSymTab.end())
+    return false;
+
+  const Comdat *DstC = &DstCI->second;
+  Comdat::SelectionKind SSK = SrcC->getSelectionKind();
+  Comdat::SelectionKind DSK = DstC->getSelectionKind();
+  return computeResultingSelectionKind(ComdatName, SSK, DSK, Result,
+                                       LinkFromSrc);
 }
 
 /// getLinkageResult - This analyzes the two global values and determines what