Add the critically missing 'clone' method. =]

Clang managed to never instantiate the copy constructor. Added tests to
ensure this path is tested.

We could still use tests for the polymorphic nature. Those coming up
next.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@194317 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/unittests/ADT/polymorphic_ptr_test.cpp b/unittests/ADT/polymorphic_ptr_test.cpp
index 3606698b35df8922eabe986bd15eda65a1ba9d08..90c3385c4f270d52e2d2dd06e8231bf980e7420b 100644 (file)
--- a/unittests/ADT/polymorphic_ptr_test.cpp
+++ b/unittests/ADT/polymorphic_ptr_test.cpp
@@ -17,9 +17,13 @@ namespace {
 
 struct S {
   S(int x) : x(x) {}
+  S *clone() { return new S(*this); }
   int x;
 };
 
+// A function that forces the return of a copy.
+polymorphic_ptr<S> dummy_copy(const polymorphic_ptr<S> &arg) { return arg; }
+
 TEST(polymorphic_ptr_test, Basic) {
   polymorphic_ptr<S> null;
   EXPECT_FALSE((bool)null);
@@ -66,6 +70,13 @@ TEST(polymorphic_ptr_test, Basic) {
   EXPECT_EQ(s, &*p);
   EXPECT_FALSE((bool)p2);
   EXPECT_TRUE(!p2);
+
+  // Force copies and that everything survives.
+  polymorphic_ptr<S> p3 = dummy_copy(polymorphic_ptr<S>(p));
+  EXPECT_TRUE((bool)p3);
+  EXPECT_FALSE(!p3);
+  EXPECT_NE(s, &*p3);
+  EXPECT_EQ(42, p3->x);
 }
 
 }