Fix read-of-uninitialized introduced in r253277 exposed on some buildbots
authorDavid Blaikie <dblaikie@gmail.com>
Tue, 17 Nov 2015 23:26:06 +0000 (23:26 +0000)
committerDavid Blaikie <dblaikie@gmail.com>
Tue, 17 Nov 2015 23:26:06 +0000 (23:26 +0000)
Verified that this was at least /an/ issue, if not the only one, by
initializing NumBuckets to 1 (previously it was uninitialized, so if
this change made a difference, which it did (causing a bunch of tests to
crash) it demonstrates use-of-uninitialized memory). Initializing then
removes the crashes.

Thanks Reid for the debugging assistance

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@253395 91177308-0d34-0410-b5e6-96231b3b80d8

include/llvm/DebugInfo/DWARF/DWARFUnitIndex.h

index f2b3010e77bc12bbca1b05e6059de657ec97f4da..0d49d7c0cf82739f7fd46fc49b93a5a58376a458 100644 (file)
@@ -33,7 +33,7 @@ class DWARFUnitIndex {
     uint32_t Version;
     uint32_t NumColumns;
     uint32_t NumUnits;
-    uint32_t NumBuckets;
+    uint32_t NumBuckets = 0;
 
     bool parse(DataExtractor IndexData, uint32_t *OffsetPtr);
     void dump(raw_ostream &OS) const;