Constant split values needs upper bound and lower bound check, just like any other...

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@41389 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Transforms/Scalar/LoopIndexSplit.cpp b/lib/Transforms/Scalar/LoopIndexSplit.cpp
index f6cb4293f6ec9fdbb5834abb98dc38392f37b0e4..a817ec5b1a4841186d130ebba2b8a99c5988a284 100644 (file)
--- a/lib/Transforms/Scalar/LoopIndexSplit.cpp
+++ b/lib/Transforms/Scalar/LoopIndexSplit.cpp
@@ -946,12 +946,6 @@ void LoopIndexSplit::calculateLoopBounds(SplitInfo &SD) {
   // values in original loop's preheader.
   //      A_ExitValue = min(SplitValue, OrignalLoopExitValue)
   //      B_StartValue = max(SplitValue, OriginalLoopStartValue)
-  if (isa<ConstantInt>(SD.SplitValue)) {
-    SD.A_ExitValue = AEV;
-    SD.B_StartValue = BSV;
-    return;
-  }
-
   Value *C1 = new ICmpInst(Sign ?
                            ICmpInst::ICMP_SLT : ICmpInst::ICMP_ULT,
                            AEV,

diff --git a/test/Transforms/LoopIndexSplit/UpperBound-2007-08-24.ll b/test/Transforms/LoopIndexSplit/UpperBound-2007-08-24.ll
new file mode 100644 (file)
index 0000000..c506451
--- /dev/null
+++ b/test/Transforms/LoopIndexSplit/UpperBound-2007-08-24.ll
@@ -0,0 +1,52 @@
+; Split loop. Split value is a constant and greater then exit value. 
+; Check whether optimizer inserts proper checkfor split value or not.
+; RUN: llvm-as < %s | opt -loop-index-split | llvm-dis | grep select
+
+@k = external global i32               ; <i32*> [#uses=2]
+
+define void @foobar(i32 %a, i32 %b) {
+entry:
+       br label %bb
+
+bb:            ; preds = %cond_next16, %entry
+       %i.01.0 = phi i32 [ 0, %entry ], [ %tmp18, %cond_next16 ]               ; <i32> [#uses=5]
+       %tsum.18.0 = phi i32 [ 42, %entry ], [ %tsum.013.1, %cond_next16 ]              ; <i32> [#uses=3]
+       %tmp1 = icmp slt i32 %i.01.0, 500               ; <i1> [#uses=1]
+       br i1 %tmp1, label %cond_true, label %cond_false
+
+cond_true:             ; preds = %bb
+       %tmp4 = tail call i32 @foo( i32 %i.01.0 )               ; <i32> [#uses=1]
+       %tmp6 = add i32 %tmp4, %tsum.18.0               ; <i32> [#uses=2]
+       %tmp914 = load i32* @k, align 4         ; <i32> [#uses=1]
+       %tmp1015 = icmp eq i32 %tmp914, 0               ; <i1> [#uses=1]
+       br i1 %tmp1015, label %cond_next16, label %cond_true13
+
+cond_false:            ; preds = %bb
+       %tmp8 = tail call i32 @bar( i32 %i.01.0 )               ; <i32> [#uses=0]
+       %tmp9 = load i32* @k, align 4           ; <i32> [#uses=1]
+       %tmp10 = icmp eq i32 %tmp9, 0           ; <i1> [#uses=1]
+       br i1 %tmp10, label %cond_next16, label %cond_true13
+
+cond_true13:           ; preds = %cond_false, %cond_true
+       %tsum.013.0 = phi i32 [ %tmp6, %cond_true ], [ %tsum.18.0, %cond_false ]                ; <i32> [#uses=1]
+       %tmp15 = tail call i32 @bar( i32 %i.01.0 )              ; <i32> [#uses=0]
+       br label %cond_next16
+
+cond_next16:           ; preds = %cond_false, %cond_true, %cond_true13
+       %tsum.013.1 = phi i32 [ %tsum.013.0, %cond_true13 ], [ %tmp6, %cond_true ], [ %tsum.18.0, %cond_false ]         ; <i32> [#uses=2]
+       %tmp18 = add i32 %i.01.0, 1             ; <i32> [#uses=3]
+       %tmp21 = icmp slt i32 %tmp18, 100               ; <i1> [#uses=1]
+       br i1 %tmp21, label %bb, label %bb24
+
+bb24:          ; preds = %cond_next16
+       %tmp18.lcssa = phi i32 [ %tmp18, %cond_next16 ]         ; <i32> [#uses=1]
+       %tsum.013.1.lcssa = phi i32 [ %tsum.013.1, %cond_next16 ]               ; <i32> [#uses=1]
+       %tmp27 = tail call i32 @t( i32 %tmp18.lcssa, i32 %tsum.013.1.lcssa )            ; <i32> [#uses=0]
+       ret void
+}
+
+declare i32 @foo(i32)
+
+declare i32 @bar(i32)
+
+declare i32 @t(i32, i32)