Revert r97245 which seems to be causing performance problems.
authorBob Wilson <bob.wilson@apple.com>
Sun, 28 Feb 2010 05:34:05 +0000 (05:34 +0000)
committerBob Wilson <bob.wilson@apple.com>
Sun, 28 Feb 2010 05:34:05 +0000 (05:34 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@97366 91177308-0d34-0410-b5e6-96231b3b80d8

include/llvm/Support/StandardPasses.h
include/llvm/Transforms/Scalar.h
lib/Transforms/Scalar/GVN.cpp

index b402e98..f233c18 100644 (file)
@@ -138,7 +138,7 @@ namespace llvm {
       PM->add(createLoopUnrollPass());          // Unroll small loops
     PM->add(createInstructionCombiningPass());  // Clean up after the unroller
     if (OptimizationLevel > 1)
-      PM->add(createGVNPass(OptimizationLevel > 2)); // Remove redundancies
+      PM->add(createGVNPass());                 // Remove redundancies
     PM->add(createMemCpyOptPass());             // Remove memcpy / form memset
     PM->add(createSCCPPass());                  // Constant prop with SCCP
   
index 4e6be46..6893bad 100644 (file)
@@ -263,8 +263,7 @@ extern const PassInfo *const LCSSAID;
 // GVN - This pass performs global value numbering and redundant load 
 // elimination cotemporaneously.
 //
-FunctionPass *createGVNPass(bool EnableFullLoadPRE = true,
-                            bool NoLoads = false);
+FunctionPass *createGVNPass(bool NoLoads = false);
 
 //===----------------------------------------------------------------------===//
 //
index c9a66fe..f7470c3 100644 (file)
@@ -60,6 +60,7 @@ STATISTIC(NumPRELoad,   "Number of loads PRE'd");
 static cl::opt<bool> EnablePRE("enable-pre",
                                cl::init(true), cl::Hidden);
 static cl::opt<bool> EnableLoadPRE("enable-load-pre", cl::init(true));
+static cl::opt<bool> EnableFullLoadPRE("enable-full-load-pre", cl::init(false));
 
 //===----------------------------------------------------------------------===//
 //                         ValueTable Class
@@ -661,12 +662,10 @@ namespace {
     bool runOnFunction(Function &F);
   public:
     static char ID; // Pass identification, replacement for typeid
-    explicit GVN(bool fullloadpre = true, bool noloads = false)
-      : FunctionPass(&ID), EnableFullLoadPRE(fullloadpre),
-        NoLoads(noloads), MD(0) { }
+    explicit GVN(bool noloads = false)
+      : FunctionPass(&ID), NoLoads(noloads), MD(0) { }
 
   private:
-    bool EnableFullLoadPRE;
     bool NoLoads;
     MemoryDependenceAnalysis *MD;
     DominatorTree *DT;
@@ -711,8 +710,8 @@ namespace {
 }
 
 // createGVNPass - The public interface to this file...
-FunctionPass *llvm::createGVNPass(bool EnableFullLoadPRE, bool NoLoads) {
-  return new GVN(EnableFullLoadPRE, NoLoads);
+FunctionPass *llvm::createGVNPass(bool NoLoads) {
+  return new GVN(NoLoads);
 }
 
 static RegisterPass<GVN> X("gvn",