Add some helpful comments on DIEValue types that we expect to hash.
authorEric Christopher <echristo@gmail.com>
Thu, 6 Mar 2014 01:32:56 +0000 (01:32 +0000)
committerEric Christopher <echristo@gmail.com>
Thu, 6 Mar 2014 01:32:56 +0000 (01:32 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203055 91177308-0d34-0410-b5e6-96231b3b80d8

lib/CodeGen/AsmPrinter/DIEHash.cpp

index bc8c6957b06cd8d2de1bc0a9f69ba66592468552..ea0c1cf7cb9be2356bff55aa11697f1eeabcc48a 100644 (file)
@@ -346,12 +346,15 @@ void DIEHash::hashAttribute(AttrEntry Attr, dwarf::Tag Tag) {
       hashBlockData(cast<DIELoc>(Value)->getValues());
     }
     break;
+    // FIXME: Handle loclistptr.
+  case DIEValue::isLocList:
+    // FIXME: It's uncertain whether or not we should handle this at the moment.
   case DIEValue::isExpr:
   case DIEValue::isLabel:
   case DIEValue::isDelta:
+    // These two were handled above.
   case DIEValue::isEntry:
   case DIEValue::isTypeSignature:
-  case DIEValue::isLocList:
     llvm_unreachable("Add support for additional value types.");
   }
 }