now that (parallel) is gone and a variety of bugs in targets
authorChris Lattner <sabre@nondot.org>
Sun, 28 Mar 2010 05:54:03 +0000 (05:54 +0000)
committerChris Lattner <sabre@nondot.org>
Sun, 28 Mar 2010 05:54:03 +0000 (05:54 +0000)
are cleaned up, we can remove an old fixme.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@99741 91177308-0d34-0410-b5e6-96231b3b80d8

lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp

index 6e5a6adbfeb243defa84bc8e096f8849276cd157..00ac9635fde1a0efaa11a9cc2216723d33aec455 100644 (file)
@@ -2687,14 +2687,10 @@ SelectCodeCommon(SDNode *NodeToMatch, const unsigned char *MatcherTable,
         assert(ResSlot < RecordedNodes.size() && "Invalid CheckSame");
         SDValue Res = RecordedNodes[ResSlot];
         
-        // FIXME2: Eliminate this horrible hack by fixing the 'Gen' program
-        // after (parallel) on input patterns are removed.  This would also
-        // allow us to stop encoding #results in OPC_CompleteMatch's table
-        // entry.
-        if (i >= NodeToMatch->getNumValues() ||
-            NodeToMatch->getValueType(i) == MVT::Other ||
-            NodeToMatch->getValueType(i) == MVT::Flag)
-          break;
+        assert(i < NodeToMatch->getNumValues() &&
+               NodeToMatch->getValueType(i) != MVT::Other &&
+               NodeToMatch->getValueType(i) != MVT::Flag &&
+               "Invalid number of results to complete!");
         assert((NodeToMatch->getValueType(i) == Res.getValueType() ||
                 NodeToMatch->getValueType(i) == MVT::iPTR ||
                 Res.getValueType() == MVT::iPTR ||