Remove some more code out into a separate CL.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@211067 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/llvm-c/Core.h b/include/llvm-c/Core.h
index 0e78ed71fa9afaf7593a2205c0db3fdc993a2af4..8693a3020aba346c811dca559662d4bf2aa6aacb 100644 (file)
--- a/include/llvm-c/Core.h
+++ b/include/llvm-c/Core.h
@@ -2848,16 +2848,13 @@ void LLVMDisposePassManager(LLVMPassManagerRef PM);
  * @{
  */
 
  * @{
  */
 

-/** Allocate and initialize structures needed to make LLVM safe for
-    multithreading. The return value indicates whether multithreaded
-    initialization succeeded. Must be executed in isolation from all
-    other LLVM api calls.
-    @see llvm::llvm_start_multithreaded */
+/** Deprecated: Multi-threading can only be enabled/disabled with the compile
+    time define LLVM_ENABLE_THREADS.  This function always returns
+    LLVMIsMultithreaded(). */

 LLVMBool LLVMStartMultithreaded(void);
 
 LLVMBool LLVMStartMultithreaded(void);
 

-/** Deallocate structures necessary to make LLVM safe for multithreading.
-    Must be executed in isolation from all other LLVM api calls.
-    @see llvm::llvm_stop_multithreaded */
+/** Deprecated: Multi-threading can only be enabled/disabled with the compile
+    time define LLVM_ENABLE_THREADS. */

 void LLVMStopMultithreaded(void);
 
 /** Check whether LLVM is executing in thread-safe mode or not.
 void LLVMStopMultithreaded(void);
 
 /** Check whether LLVM is executing in thread-safe mode or not.

diff --git a/include/llvm/Support/ManagedStatic.h b/include/llvm/Support/ManagedStatic.h
index 1bb8cea092f9b693f14f5f840d4b4be80f637c4d..d8fbfeb8e20cee089f8985d1ff9aa70a2a4515ca 100644 (file)
--- a/include/llvm/Support/ManagedStatic.h
+++ b/include/llvm/Support/ManagedStatic.h
@@ -103,9 +103,6 @@ void llvm_shutdown();
 /// llvm_shutdown() when it is destroyed.
 struct llvm_shutdown_obj {
   llvm_shutdown_obj() { }
 /// llvm_shutdown() when it is destroyed.
 struct llvm_shutdown_obj {
   llvm_shutdown_obj() { }

-  explicit llvm_shutdown_obj(bool multithreaded) {
-    if (multithreaded) llvm_start_multithreaded();
-  }

   ~llvm_shutdown_obj() { llvm_shutdown(); }
 };
 
   ~llvm_shutdown_obj() { llvm_shutdown(); }
 };
 

diff --git a/include/llvm/Support/Threading.h b/include/llvm/Support/Threading.h
index 4768d86de991c002891e270c2f44f32dee4a5728..e33b52f90716af94f3cf1656db7bdb49430e4a35 100644 (file)
--- a/include/llvm/Support/Threading.h
+++ b/include/llvm/Support/Threading.h
@@ -7,7 +7,8 @@
 //
 //===----------------------------------------------------------------------===//
 //
 //
 //===----------------------------------------------------------------------===//
 //

-// TThis file defines llvm_start_multithreaded() and friends.
+// This file defines helper functions for running LLVM in a multi-threaded
+// environment.

 //
 //===----------------------------------------------------------------------===//
 
 //
 //===----------------------------------------------------------------------===//
 


@@ -17,25 +18,12 @@
 #include "llvm/Support/Mutex.h"
 
 namespace llvm {
 #include "llvm/Support/Mutex.h"
 
 namespace llvm {

-  /// llvm_get_global_lock - returns the llvm global lock object.
-  sys::Mutex& llvm_get_global_lock();

 
 

-  /// llvm_start_multithreaded - Allocate and initialize structures needed to
-  /// make LLVM safe for multithreading.  The return value indicates whether
-  /// multithreaded initialization succeeded.  LLVM will still be operational
-  /// on "failed" return, and will still be safe for hosting threading
-  /// applications in the JIT, but will not be safe for concurrent calls to the
-  /// LLVM APIs.
-  /// THIS MUST EXECUTE IN ISOLATION FROM ALL OTHER LLVM API CALLS.
-  bool llvm_start_multithreaded();
+  /// llvm_get_global_lock() - returns the llvm global lock object.
+  sys::Mutex &llvm_get_global_lock();

 
 

-  /// llvm_stop_multithreaded - Deallocate structures necessary to make LLVM
-  /// safe for multithreading.
-  /// THIS MUST EXECUTE IN ISOLATION FROM ALL OTHER LLVM API CALLS.
-  void llvm_stop_multithreaded();
-
-  /// llvm_is_multithreaded - Check whether LLVM is executing in thread-safe
-  /// mode or not.
+  /// llvm_is_multithreaded() - returns true if LLVM is compiled with support
+  /// for multiple threads, and false otherwise.

   bool llvm_is_multithreaded();
 
   /// llvm_execute_on_thread - Execute the given \p UserFn on a separate
   bool llvm_is_multithreaded();
 
   /// llvm_execute_on_thread - Execute the given \p UserFn on a separate

diff --git a/lib/IR/Core.cpp b/lib/IR/Core.cpp
index 197b6cb9054e7f008a6e90ab7dd2d2293b314c26..68b9baa2baa2e37d1b0fb7cd212923cfcd915fd7 100644 (file)
--- a/lib/IR/Core.cpp
+++ b/lib/IR/Core.cpp
@@ -2702,11 +2702,10 @@ void LLVMDisposePassManager(LLVMPassManagerRef PM) {
 /*===-- Threading ------------------------------------------------------===*/
 
 LLVMBool LLVMStartMultithreaded() {
 /*===-- Threading ------------------------------------------------------===*/
 
 LLVMBool LLVMStartMultithreaded() {

-  return llvm_start_multithreaded();
+  return LLVMIsMultithreaded();

 }
 
 void LLVMStopMultithreaded() {
 }
 
 void LLVMStopMultithreaded() {

-  llvm_stop_multithreaded();

 }
 
 LLVMBool LLVMIsMultithreaded() {
 }
 
 LLVMBool LLVMIsMultithreaded() {

diff --git a/lib/Support/ManagedStatic.cpp b/lib/Support/ManagedStatic.cpp
index 6f5cf6bcb1a8f08594ba4e6afa066d4227f71e20..76f86e398de6621129a6f126e89b14deb5aef441 100644 (file)
--- a/lib/Support/ManagedStatic.cpp
+++ b/lib/Support/ManagedStatic.cpp
@@ -24,7 +24,7 @@ void ManagedStaticBase::RegisterManagedStatic(void *(*Creator)(),
                                               void (*Deleter)(void*)) const {
   assert(Creator);
   if (llvm_is_multithreaded()) {
                                               void (*Deleter)(void*)) const {
   assert(Creator);
   if (llvm_is_multithreaded()) {

-    llvm::MutexGuard Lock(llvm::llvm_get_global_lock());
+    llvm::MutexGuard Lock(llvm_get_global_lock());

 
     if (!Ptr) {
       void* tmp = Creator();
 
     if (!Ptr) {
       void* tmp = Creator();


@@ -76,6 +76,4 @@ void ManagedStaticBase::destroy() const {
 void llvm::llvm_shutdown() {
   while (StaticList)
     StaticList->destroy();
 void llvm::llvm_shutdown() {
   while (StaticList)
     StaticList->destroy();

-
-  if (llvm_is_multithreaded()) llvm_stop_multithreaded();

 }
 }

diff --git a/lib/Support/Threading.cpp b/lib/Support/Threading.cpp
index 33943efcd683e8232152fa8a4a8e038f363ce771..ff591aaa1d8fb08dc62f991a273df50e077d5718 100644 (file)
--- a/lib/Support/Threading.cpp
+++ b/lib/Support/Threading.cpp
@@ -7,7 +7,8 @@
 //
 //===----------------------------------------------------------------------===//
 //
 //
 //===----------------------------------------------------------------------===//
 //

-// This file implements llvm_start_multithreaded() and friends.
+// This file implements helper functions for running LLVM in a multi-threaded
+// environment.

 //
 //===----------------------------------------------------------------------===//
 
 //
 //===----------------------------------------------------------------------===//
 


@@ -19,43 +20,19 @@
 
 using namespace llvm;
 
 
 using namespace llvm;
 

-static bool multithreaded_mode = false;
-

 sys::Mutex& llvm::llvm_get_global_lock() {
   static sys::Mutex global_lock;
   return global_lock;
 }
 
 sys::Mutex& llvm::llvm_get_global_lock() {
   static sys::Mutex global_lock;
   return global_lock;
 }
 

-bool llvm::llvm_start_multithreaded() {
+bool llvm::llvm_is_multithreaded() {

 #if LLVM_ENABLE_THREADS != 0
 #if LLVM_ENABLE_THREADS != 0

-  assert(!multithreaded_mode && "Already multithreaded!");
-  multithreaded_mode = true;
-
-  // We fence here to ensure that all initialization is complete BEFORE we
-  // return from llvm_start_multithreaded().
-  sys::MemoryFence();

   return true;
 #else
   return false;
 #endif
 }
 
   return true;
 #else
   return false;
 #endif
 }
 

-void llvm::llvm_stop_multithreaded() {
-#if LLVM_ENABLE_THREADS != 0
-  assert(multithreaded_mode && "Not currently multithreaded!");
-
-  // We fence here to insure that all threaded operations are complete BEFORE we
-  // return from llvm_stop_multithreaded().
-  sys::MemoryFence();
-
-  multithreaded_mode = false;
-#endif
-}
-
-bool llvm::llvm_is_multithreaded() {
-  return multithreaded_mode;
-}
-

 #if LLVM_ENABLE_THREADS != 0 && defined(HAVE_PTHREAD_H)
 #include <pthread.h>
 
 #if LLVM_ENABLE_THREADS != 0 && defined(HAVE_PTHREAD_H)
 #include <pthread.h>
 

diff --git a/lib/Support/Timer.cpp b/lib/Support/Timer.cpp
index 417ac8d6bb4a4f563e9484662dc16e00004284a4..c7427260bff7518ccbfd216637380fe2a0b0459f 100644 (file)
--- a/lib/Support/Timer.cpp
+++ b/lib/Support/Timer.cpp
@@ -18,7 +18,7 @@
 #include "llvm/Support/FileSystem.h"
 #include "llvm/Support/Format.h"
 #include "llvm/Support/ManagedStatic.h"
 #include "llvm/Support/FileSystem.h"
 #include "llvm/Support/Format.h"
 #include "llvm/Support/ManagedStatic.h"

-#include "llvm/support/MutexGuard.h"
+#include "llvm/Support/MutexGuard.h"

 #include "llvm/Support/Process.h"
 #include "llvm/Support/raw_ostream.h"
 using namespace llvm;
 #include "llvm/Support/Process.h"
 #include "llvm/Support/raw_ostream.h"
 using namespace llvm;

diff --git a/unittests/Support/ManagedStatic.cpp b/unittests/Support/ManagedStatic.cpp
index ad2fc977e6d7f150a3c898e838fb38116511f2f9..153884ba42986a9d32e5d1bd241f176cad1d20b9 100644 (file)
--- a/unittests/Support/ManagedStatic.cpp
+++ b/unittests/Support/ManagedStatic.cpp
@@ -47,7 +47,6 @@ TEST(Initialize, MultipleThreads) {
   void *p1 = test1::allocate_stack(a1);
   void *p2 = test1::allocate_stack(a2);
 
   void *p1 = test1::allocate_stack(a1);
   void *p2 = test1::allocate_stack(a2);
 

-  llvm_start_multithreaded();

   pthread_t t1, t2;
   pthread_create(&t1, &a1, test1::helper, nullptr);
   pthread_create(&t2, &a2, test1::helper, nullptr);
   pthread_t t1, t2;
   pthread_create(&t1, &a1, test1::helper, nullptr);
   pthread_create(&t2, &a2, test1::helper, nullptr);


@@ -55,7 +54,6 @@ TEST(Initialize, MultipleThreads) {
   pthread_join(t2, nullptr);
   free(p1);
   free(p2);
   pthread_join(t2, nullptr);
   free(p1);
   free(p2);

-  llvm_stop_multithreaded();

 }
 #endif
 
 }
 #endif