It emits *millions of warnings* during selfhosting LTO build, to choke the buildbot with gigbytes of log.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@230885
91177308-0d34-0410-b5e6-
96231b3b80d8
+++ /dev/null
-; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
-; RUN: --plugin-opt=emit-llvm -shared %p/Inputs/drop-debug.bc \
-; RUN: -o t2.bc 2>&1 | FileCheck %s
-
-; drop-debug.bc was created from "void f(void) {}" with clang 3.5 and
-; -gline-tables-only, so it contains old debug info.
-
-; CHECK: warning: LLVM gold plugin: ignoring debug info with an invalid version (1) in {{.*}}/Inputs/drop-debug.bc
#include "llvm/Bitcode/ReaderWriter.h"
#include "llvm/CodeGen/Analysis.h"
#include "llvm/CodeGen/CommandFlags.h"
#include "llvm/Bitcode/ReaderWriter.h"
#include "llvm/CodeGen/Analysis.h"
#include "llvm/CodeGen/CommandFlags.h"
-#include "llvm/IR/AutoUpgrade.h"
#include "llvm/IR/Constants.h"
#include "llvm/IR/DiagnosticInfo.h"
#include "llvm/IR/DiagnosticPrinter.h"
#include "llvm/IR/Constants.h"
#include "llvm/IR/DiagnosticInfo.h"
#include "llvm/IR/DiagnosticPrinter.h"
}
static void diagnosticHandler(const DiagnosticInfo &DI, void *Context) {
}
static void diagnosticHandler(const DiagnosticInfo &DI, void *Context) {
- if (const auto *BDI = dyn_cast<BitcodeDiagnosticInfo>(&DI)) {
- std::error_code EC = BDI->getError();
- if (EC == BitcodeError::InvalidBitcodeSignature)
- return;
- }
+ assert(DI.getSeverity() == DS_Error && "Only expecting errors");
+ const auto &BDI = cast<BitcodeDiagnosticInfo>(DI);
+ std::error_code EC = BDI.getError();
+ if (EC == BitcodeError::InvalidBitcodeSignature)
+ return;
std::string ErrStorage;
{
std::string ErrStorage;
{
DiagnosticPrinterRawOStream DP(OS);
DI.print(DP);
}
DiagnosticPrinterRawOStream DP(OS);
DI.print(DP);
}
- ld_plugin_level Level;
- switch (DI.getSeverity()) {
- case DS_Error:
- message(LDPL_FATAL, "LLVM gold plugin has failed to create LTO module: %s",
- ErrStorage.c_str());
- llvm_unreachable("Fatal doesn't return.");
- case DS_Warning:
- Level = LDPL_WARNING;
- break;
- case DS_Remark:
- case DS_Note:
- Level = LDPL_INFO;
- break;
- }
- message(Level, "LLVM gold plugin: %s", ErrStorage.c_str());
+ message(LDPL_FATAL, "LLVM gold plugin has failed to create LTO module: %s",
+ ErrStorage.c_str());
}
/// Called by gold to see whether this file is one that our plugin can handle.
}
/// Called by gold to see whether this file is one that our plugin can handle.
static std::unique_ptr<Module>
getModuleForFile(LLVMContext &Context, claimed_file &F,
static std::unique_ptr<Module>
getModuleForFile(LLVMContext &Context, claimed_file &F,
- ld_plugin_input_file &Info, raw_fd_ostream *ApiFile,
+ off_t Filesize, raw_fd_ostream *ApiFile,
StringSet<> &Internalize, StringSet<> &Maybe) {
if (get_symbols(F.handle, F.syms.size(), &F.syms[0]) != LDPS_OK)
StringSet<> &Internalize, StringSet<> &Maybe) {
if (get_symbols(F.handle, F.syms.size(), &F.syms[0]) != LDPS_OK)
if (get_view(F.handle, &View) != LDPS_OK)
message(LDPL_FATAL, "Failed to get a view of file");
if (get_view(F.handle, &View) != LDPS_OK)
message(LDPL_FATAL, "Failed to get a view of file");
- MemoryBufferRef BufferRef(StringRef((const char *)View, Info.filesize),
- Info.name);
+ MemoryBufferRef BufferRef(StringRef((const char *)View, Filesize), "");
ErrorOr<std::unique_ptr<object::IRObjectFile>> ObjOrErr =
object::IRObjectFile::create(BufferRef, Context);
ErrorOr<std::unique_ptr<object::IRObjectFile>> ObjOrErr =
object::IRObjectFile::create(BufferRef, Context);
Module &M = Obj.getModule();
Module &M = Obj.getModule();
SmallPtrSet<GlobalValue *, 8> Used;
collectUsedGlobalVariables(M, Used, /*CompilerUsed*/ false);
SmallPtrSet<GlobalValue *, 8> Used;
collectUsedGlobalVariables(M, Used, /*CompilerUsed*/ false);
return LDPS_OK;
LLVMContext Context;
return LDPS_OK;
LLVMContext Context;
- Context.setDiagnosticHandler(diagnosticHandler);
-
std::unique_ptr<Module> Combined(new Module("ld-temp.o", Context));
Linker L(Combined.get());
std::unique_ptr<Module> Combined(new Module("ld-temp.o", Context));
Linker L(Combined.get());
if (get_input_file(F.handle, &File) != LDPS_OK)
message(LDPL_FATAL, "Failed to get file information");
std::unique_ptr<Module> M =
if (get_input_file(F.handle, &File) != LDPS_OK)
message(LDPL_FATAL, "Failed to get file information");
std::unique_ptr<Module> M =
- getModuleForFile(Context, F, File, ApiFile, Internalize, Maybe);
+ getModuleForFile(Context, F, File.filesize, ApiFile,
+ Internalize, Maybe);
if (!options::triple.empty())
M->setTargetTriple(options::triple.c_str());
else if (M->getTargetTriple().empty()) {
if (!options::triple.empty())
M->setTargetTriple(options::triple.c_str());
else if (M->getTargetTriple().empty()) {