Reduce double set lookups.
authorBenjamin Kramer <benny.kra@googlemail.com>
Fri, 27 Feb 2015 21:43:14 +0000 (21:43 +0000)
committerBenjamin Kramer <benny.kra@googlemail.com>
Fri, 27 Feb 2015 21:43:14 +0000 (21:43 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@230798 91177308-0d34-0410-b5e6-96231b3b80d8

include/llvm/ADT/DepthFirstIterator.h
lib/Analysis/LazyValueInfo.cpp
lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h

index 6cd9e68aea56c87a3eda598948062543caea0713..657fe6867f2da242be58b7d1b7d9d11cc007e9c7 100644 (file)
@@ -113,9 +113,8 @@ private:
       while (It != GT::child_end(Node)) {
         NodeType *Next = *It++;
         // Has our next sibling been visited?
-        if (Next && !this->Visited.count(Next)) {  
+        if (Next && this->Visited.insert(Next).second) {
           // No, do it now.
-          this->Visited.insert(Next);
           VisitStack.push_back(std::make_pair(PointerIntTy(Next, 0), 
                                               GT::child_begin(Next)));
           return;
index 87c31fd9b68b0ff50a61ef367a2dd697fd0ff1c3..d4580dcee84c0ee5b1d8dc138de60a9dba3e931b 100644 (file)
@@ -346,11 +346,10 @@ namespace {
     /// Push BV onto BlockValueStack unless it's already in there.
     /// Returns true on success.
     bool pushBlockValue(const std::pair<BasicBlock *, Value *> &BV) {
-      if (BlockValueSet.count(BV))
+      if (!BlockValueSet.insert(BV).second)
         return false;  // It's already in the stack.
 
       BlockValueStack.push(BV);
-      BlockValueSet.insert(BV);
       return true;
     }
 
index ad7411f7775bb58123f5c85b71f94bd2933a795b..719af410245a56b925f6f831d6d4e1a83a76fa08 100644 (file)
@@ -622,8 +622,7 @@ public:
   void removeValue(const Value *V) {
     // This is to support hack in lowerCallFromStatepoint
     // Should be removed when hack is resolved
-    if (NodeMap.count(V))
-      NodeMap.erase(V);
+    NodeMap.erase(V);
   }
 
   void setUnusedArgValue(const Value *V, SDValue NewN) {