Remove assignPassManager's default arguments. It's really
authorDan Gohman <gohman@apple.com>
Sat, 7 Aug 2010 01:25:32 +0000 (01:25 +0000)
committerDan Gohman <gohman@apple.com>
Sat, 7 Aug 2010 01:25:32 +0000 (01:25 +0000)
confusing to have different arguments for the same virtual
function at different levels of the class hierarchy.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@110500 91177308-0d34-0410-b5e6-96231b3b80d8

include/llvm/Analysis/LoopPass.h
include/llvm/CallGraphSCCPass.h
include/llvm/Pass.h

index 0d92de79f9c371fe65711fcfe43df39ce9b80637..1e59b969e43ffeeec0c97d752b2a24a83035a8c8 100644 (file)
@@ -58,7 +58,7 @@ public:
 
   /// Assign pass manager to manage this pass
   virtual void assignPassManager(PMStack &PMS,
-                                 PassManagerType PMT = PMT_LoopPassManager);
+                                 PassManagerType PMT);
 
   ///  Return what kind of Pass Manager can manage this pass.
   virtual PassManagerType getPotentialPassManagerType() const {
index 5fa8b0e574a2676a627f82491be68117360a9952..7154aa3259d2927350bb8d282c109764245bb603 100644 (file)
@@ -63,7 +63,7 @@ public:
 
   /// Assign pass manager to manager this pass
   virtual void assignPassManager(PMStack &PMS,
-                                 PassManagerType PMT =PMT_CallGraphPassManager);
+                                 PassManagerType PMT);
 
   ///  Return what kind of Pass Manager can manage this pass.
   virtual PassManagerType getPotentialPassManagerType() const {
index 70d692d507b7db35ee5e7977a16a7505fb6888af..4cbf27b98b4d3ed245126273ec4ef90421eadc18 100644 (file)
@@ -119,7 +119,7 @@ public:
   /// Each pass is responsible for assigning a pass manager to itself.
   /// PMS is the stack of available pass manager. 
   virtual void assignPassManager(PMStack &, 
-                                 PassManagerType = PMT_Unknown) {}
+                                 PassManagerType) {}
   /// Check if available pass managers are suitable for this pass or not.
   virtual void preparePassManager(PMStack &);
   
@@ -225,7 +225,7 @@ public:
   virtual bool runOnModule(Module &M) = 0;
 
   virtual void assignPassManager(PMStack &PMS, 
-                                 PassManagerType T = PMT_ModulePassManager);
+                                 PassManagerType T);
 
   ///  Return what kind of Pass Manager can manage this pass.
   virtual PassManagerType getPotentialPassManagerType() const;
@@ -307,7 +307,7 @@ public:
   bool run(Function &F);
 
   virtual void assignPassManager(PMStack &PMS, 
-                                 PassManagerType T = PMT_FunctionPassManager);
+                                 PassManagerType T);
 
   ///  Return what kind of Pass Manager can manage this pass.
   virtual PassManagerType getPotentialPassManagerType() const;
@@ -364,7 +364,7 @@ public:
   bool runOnFunction(Function &F);
 
   virtual void assignPassManager(PMStack &PMS, 
-                                 PassManagerType T = PMT_BasicBlockPassManager);
+                                 PassManagerType T);
 
   ///  Return what kind of Pass Manager can manage this pass.
   virtual PassManagerType getPotentialPassManagerType() const;