Don't commit stores with addresses that have indices that are not

compile-time constant integers or that are out of bounds for their
corresponding static array types. These can cause aliasing that
GlobalOpt assumes won't happen.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@81165 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Transforms/IPO/GlobalOpt.cpp b/lib/Transforms/IPO/GlobalOpt.cpp
index 86c5e2919483ce92b24001527cc2d9e1924d9be1..b995a3d2864da9726a336449dfa994d092a4744c 100644 (file)
--- a/lib/Transforms/IPO/GlobalOpt.cpp
+++ b/lib/Transforms/IPO/GlobalOpt.cpp
@@ -2044,6 +2044,27 @@ static bool isSimpleEnoughPointerToCommit(Constant *C, LLVMContext &Context) {
       // external globals.
       if (!GV->hasDefinitiveInitializer())
         return false;
       // external globals.
       if (!GV->hasDefinitiveInitializer())
         return false;

+
+      gep_type_iterator GEPI = gep_type_begin(CE), E = gep_type_end(CE);
+      User::op_iterator OI = next(CE->op_begin());
+
+      // The first index must be zero.
+      ConstantInt *CI = dyn_cast<ConstantInt>(*OI);
+      if (!CI || !CI->isZero()) return false;
+      ++GEPI;
+      ++OI;
+
+      // The remaining indices must be compile-time known integers within the
+      // bounds of the corresponding static array types.
+      for (; GEPI != E; ++GEPI, ++OI) {
+        CI = dyn_cast<ConstantInt>(*OI);
+        if (!CI) return false;
+        if (const ArrayType *ATy = dyn_cast<ArrayType>(*GEPI))
+          if (CI->getValue().getActiveBits() > 64 ||
+              CI->getZExtValue() >= ATy->getNumElements())
+            return false;
+      }
+

       return ConstantFoldLoadThroughGEPConstantExpr(GV->getInitializer(), CE,
                                                     Context);
     }
       return ConstantFoldLoadThroughGEPConstantExpr(GV->getInitializer(), CE,
                                                     Context);
     }