Don't muck with phi nodes; bug fixes.
authorEvan Cheng <evan.cheng@apple.com>
Wed, 12 Dec 2007 02:53:41 +0000 (02:53 +0000)
committerEvan Cheng <evan.cheng@apple.com>
Wed, 12 Dec 2007 02:53:41 +0000 (02:53 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@44905 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Transforms/Scalar/CodeGenPrepare.cpp

index 37a645f3ce813b492bfe975e4b770f13b3582f37..47e60cd74b4d50dd540a920114afcdc8d508d4c6 100644 (file)
@@ -930,8 +930,8 @@ bool CodeGenPrepare::OptimizeExtUses(Instruction *I) {
     return false;
 
   // Only safe to perform the optimization if the source is also defined in
-  // this block. 
-  if (DefBB != cast<Instruction>(Src)->getParent())
+  // this block.
+  if (!isa<Instruction>(Src) || DefBB != cast<Instruction>(Src)->getParent())
     return false;
 
   bool DefIsLiveOut = false;
@@ -948,6 +948,15 @@ bool CodeGenPrepare::OptimizeExtUses(Instruction *I) {
   if (!DefIsLiveOut)
     return false;
 
+  // Make sure non of the uses are PHI nodes.
+  for (Value::use_iterator UI = Src->use_begin(), E = Src->use_end(); 
+       UI != E; ++UI) {
+    Instruction *User = cast<Instruction>(*UI);
+    if (User->getParent() == DefBB) continue;
+    if (isa<PHINode>(User))
+      return false;
+  }
+
   // InsertedTruncs - Only insert one trunc in each block once.
   DenseMap<BasicBlock*, Instruction*> InsertedTruncs;