A couple of kill marker maintainence bug.
authorEvan Cheng <evan.cheng@apple.com>
Fri, 21 Mar 2008 19:09:30 +0000 (19:09 +0000)
committerEvan Cheng <evan.cheng@apple.com>
Fri, 21 Mar 2008 19:09:30 +0000 (19:09 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@48653 91177308-0d34-0410-b5e6-96231b3b80d8

lib/CodeGen/SimpleRegisterCoalescing.cpp
lib/CodeGen/VirtRegMap.cpp

index cc413c3855f3a4e9269b06575c72d444a7f80fb6..6326edab3490fd3824d7cade29efbb7cec5020b6 100644 (file)
@@ -432,6 +432,7 @@ SimpleRegisterCoalescing::UpdateRegDefsUses(unsigned SrcReg, unsigned DstReg,
   for (MachineRegisterInfo::reg_iterator I = mri_->reg_begin(SrcReg),
          E = mri_->reg_end(); I != E; ) {
     MachineOperand &O = I.getOperand();
+    MachineInstr *UseMI = &*I;
     ++I;
     if (DstIsPhys) {
       unsigned UseSubIdx = O.getSubReg();
@@ -451,6 +452,9 @@ SimpleRegisterCoalescing::UpdateRegDefsUses(unsigned SrcReg, unsigned DstReg,
         assert(OldSubIdx < SubIdx && "Conflicting sub-register index!");
       else if (SubIdx)
         O.setSubReg(SubIdx);
+      // Remove would-be duplicated kill marker.
+      if (O.isKill() && UseMI->killsRegister(DstReg))
+        O.setIsKill(false);
       O.setReg(DstReg);
     }
   }
index b094412ae859e1997f5850cfcddd6afcce849fce..f89ef9a8b5d09759ba7a8f1d760ef62a3477e598 100644 (file)
@@ -610,7 +610,7 @@ static void UpdateKills(MachineInstr &MI, BitVector &RegKills,
     if (Reg == 0)
       continue;
     
-    if (RegKills[Reg]) {
+    if (RegKills[Reg] && KillOps[Reg]->getParent() != &MI) {
       // That can't be right. Register is killed but not re-defined and it's
       // being reused. Let's fix that.
       KillOps[Reg]->setIsKill(false);