Help GCC along with code that's actually unreachable.
authorDavid Blaikie <dblaikie@gmail.com>
Sun, 22 Jan 2012 01:17:04 +0000 (01:17 +0000)
committerDavid Blaikie <dblaikie@gmail.com>
Sun, 22 Jan 2012 01:17:04 +0000 (01:17 +0000)
Unfortunately I don't think there's a fix for this that will work upstream and
also satisfy Clang's -Wunreachable-code, which is a pity. But I'll give it some
more thought -perhaps there's some way out.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@148645 91177308-0d34-0410-b5e6-96231b3b80d8

utils/unittest/googletest/gtest.cc

index 653892404f5b7daa6a8782b72db9117298238711..3fdff0a9a3559f364fa7efdb225b59f4a7752970 100644 (file)
@@ -2481,6 +2481,9 @@ static const char * TestPartResultTypeToString(TestPartResult::Type type) {
       return "Failure\n";
 #endif
   }
+
+  // All cases return, so this is unreachable but GCC doesn't know it
+  abort();
 }
 
 // Prints a TestPartResult to a String.