Fix a logic error. An instruction that has a live physical register def cannot be...

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@97688 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/CodeGen/MachineCSE.cpp b/lib/CodeGen/MachineCSE.cpp
index ea11bfbdb89f43395df8895b86364d0be10a3ff0..d542cc9969a0ea4eca890d87fb28d8cf0307e60a 100644 (file)
--- a/lib/CodeGen/MachineCSE.cpp
+++ b/lib/CodeGen/MachineCSE.cpp
@@ -128,8 +128,6 @@ bool MachineCSE::ProcessBlock(MachineDomTreeNode *Node) {
     if (TII->isMoveInstr(*MI, SrcReg, DstReg, SrcSubIdx, DstSubIdx) ||
         MI->isExtractSubreg() || MI->isInsertSubreg() || MI->isSubregToReg())
       continue;    
-    if (hasLivePhysRegDefUse(MI))
-      continue;
 
     bool FoundCSE = VNT.count(MI);
     if (!FoundCSE) {
@@ -138,6 +136,11 @@ bool MachineCSE::ProcessBlock(MachineDomTreeNode *Node) {
         FoundCSE = VNT.count(MI);
     }
 
+    // If the instruction defines a physical register and the value *may* be
+    // used, then it's not safe to replace it with a common subexpression.
+    if (FoundCSE && hasLivePhysRegDefUse(MI))
+      FoundCSE = false;
+
     if (!FoundCSE) {
       VNT.insert(MI, CurrVN++);
       Exps.push_back(MI);