Eliminate repeated allocation of a per-BB DenseMap for a 4.6% reduction of time
authorCameron Zwarich <zwarich@apple.com>
Tue, 4 Jan 2011 06:42:27 +0000 (06:42 +0000)
committerCameron Zwarich <zwarich@apple.com>
Tue, 4 Jan 2011 06:42:27 +0000 (06:42 +0000)
spent in StrongPHIElimination on 403.gcc.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@122803 91177308-0d34-0410-b5e6-96231b3b80d8

lib/CodeGen/StrongPHIElimination.cpp

index 91ec13df643c8101957721e56d8adfb76ef613ec..54c6647f05904f039b69827a8cc9523f65ed5c56 100644 (file)
@@ -144,6 +144,10 @@ namespace {
     // sources.
     DenseMap<MachineBasicBlock*, std::vector<MachineInstr*> > PHISrcDefs;
 
+    // Maps a color to a pair of a MachineInstr* and a virtual register, which
+    // is the operand of that PHI corresponding to the current basic block.
+    DenseMap<unsigned, std::pair<MachineInstr*, unsigned> > CurrentPHIForColor;
+
     // FIXME: Can these two data structures be combined? Would a std::multimap
     // be any better?
 
@@ -567,12 +571,7 @@ StrongPHIElimination::SplitInterferencesForBasicBlock(
   // the predecessor block. The def of a PHI's destination register is processed
   // along with the other defs in a basic block.
 
-  // The map CurrentPHIForColor maps a color to a pair of a MachineInstr* and a
-  // virtual register, which is the operand of that PHI corresponding to the
-  // current basic block.
-  // FIXME: This should use a container that doesn't always perform heap
-  // allocation.
-  DenseMap<unsigned, std::pair<MachineInstr*, unsigned> > CurrentPHIForColor;
+  CurrentPHIForColor.clear();
 
   for (MachineBasicBlock::succ_iterator SI = MBB.succ_begin(),
        SE = MBB.succ_end(); SI != SE; ++SI) {