Work around a bug in GCC where it can't handle common variables marked weak.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@9679 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Target/CBackend/CBackend.cpp b/lib/Target/CBackend/CBackend.cpp
index 0fd3046021432566a34c01feb0ce4fbb8e4eb266..258c2878787585cce8a82ddc3120ec7e6fc6abe0 100644 (file)
--- a/lib/Target/CBackend/CBackend.cpp
+++ b/lib/Target/CBackend/CBackend.cpp
@@ -693,7 +693,14 @@ void CWriter::printModule(Module *M) {
           Out << " __attribute__((common))";
         else if (I->hasWeakLinkage())
           Out << " __attribute__((weak))";
-        if (!I->getInitializer()->isNullValue()) {
+
+        // If the initializer is not null, emit the initializer.  If it is null,
+        // we try to avoid emitting large amounts of zeros.  The problem with
+        // this, however, occurs when the variable has weak linkage.  In this
+        // case, the assembler will complain about the variable being both weak
+        // and common, so we disable this optimization.
+        if (!I->getInitializer()->isNullValue() ||
+            I->hasWeakLinkage()) {
           Out << " = " ;
           writeOperand(I->getInitializer());
         }

diff --git a/lib/Target/CBackend/Writer.cpp b/lib/Target/CBackend/Writer.cpp
index 0fd3046021432566a34c01feb0ce4fbb8e4eb266..258c2878787585cce8a82ddc3120ec7e6fc6abe0 100644 (file)
--- a/lib/Target/CBackend/Writer.cpp
+++ b/lib/Target/CBackend/Writer.cpp
@@ -693,7 +693,14 @@ void CWriter::printModule(Module *M) {
           Out << " __attribute__((common))";
         else if (I->hasWeakLinkage())
           Out << " __attribute__((weak))";
-        if (!I->getInitializer()->isNullValue()) {
+
+        // If the initializer is not null, emit the initializer.  If it is null,
+        // we try to avoid emitting large amounts of zeros.  The problem with
+        // this, however, occurs when the variable has weak linkage.  In this
+        // case, the assembler will complain about the variable being both weak
+        // and common, so we disable this optimization.
+        if (!I->getInitializer()->isNullValue() ||
+            I->hasWeakLinkage()) {
           Out << " = " ;
           writeOperand(I->getInitializer());
         }