Revert "Walk back commits for unused function parameters - they're still being"

this reapplies 208012 and 208002.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@208037 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/llvm/MC/SubtargetFeature.h b/include/llvm/MC/SubtargetFeature.h
index d0735ccd9fa3179414314398457923a5d159ba85..d9bea4b917b5d47bed9a536472c34656f7e59945 100644 (file)
--- a/include/llvm/MC/SubtargetFeature.h
+++ b/include/llvm/MC/SubtargetFeature.h
@@ -78,7 +78,7 @@ public:
   std::string getString() const;
 
   /// Adding Features.
   std::string getString() const;
 
   /// Adding Features.

-  void AddFeature(const StringRef String, bool IsEnabled = true);
+  void AddFeature(const StringRef String);

 
   /// ToggleFeature - Toggle a feature and returns the newly updated feature
   /// bits.
 
   /// ToggleFeature - Toggle a feature and returns the newly updated feature
   /// bits.

diff --git a/lib/MC/SubtargetFeature.cpp b/lib/MC/SubtargetFeature.cpp
index 6af92c74a42f97bea8c7602d55cb0acb685391fb..dd69b0fe8c0169dbc590bb2d3ffcd3ba6fcf63d7 100644 (file)
--- a/lib/MC/SubtargetFeature.cpp
+++ b/lib/MC/SubtargetFeature.cpp
@@ -51,18 +51,6 @@ static inline bool isEnabled(const StringRef Feature) {
   return Ch == '+';
 }
 
   return Ch == '+';
 }
 

-/// PrependFlag - Return a string with a prepended flag; '+' or '-'.
-///
-static inline std::string PrependFlag(const StringRef Feature,
-                                    bool IsEnabled) {
-  assert(!Feature.empty() && "Empty string");
-  if (hasFlag(Feature))
-    return Feature;
-  std::string Prefix = IsEnabled ? "+" : "-";
-  Prefix += Feature;
-  return Prefix;
-}
-

 /// Split - Splits a string of comma separated items in to a vector of strings.
 ///
 static void Split(std::vector<std::string> &V, const StringRef S) {
 /// Split - Splits a string of comma separated items in to a vector of strings.
 ///
 static void Split(std::vector<std::string> &V, const StringRef S) {


@@ -109,13 +97,11 @@ static std::string Join(const std::vector<std::string> &V) {
 }
 
 /// Adding features.
 }
 
 /// Adding features.

-void SubtargetFeatures::AddFeature(const StringRef String,
-                                   bool IsEnabled) {
-  // Don't add empty features
-  if (!String.empty()) {
-    // Convert to lowercase, prepend flag and add to vector
-    Features.push_back(PrependFlag(String.lower(), IsEnabled));
-  }
+void SubtargetFeatures::AddFeature(const StringRef String) {
+  // Don't add empty features or features we already have.
+  if (!String.empty())
+    // Convert to lowercase, prepend flag if we don't already have a flag.
+    Features.push_back(hasFlag(String) ? String.str() : "+" + String.lower());

 }
 
 /// Find KV in array using binary search.
 }
 
 /// Find KV in array using binary search.