Add comments for missed opportunities.
authorEvan Cheng <evan.cheng@apple.com>
Wed, 7 Apr 2010 06:00:33 +0000 (06:00 +0000)
committerEvan Cheng <evan.cheng@apple.com>
Wed, 7 Apr 2010 06:00:33 +0000 (06:00 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@100610 91177308-0d34-0410-b5e6-96231b3b80d8

lib/CodeGen/MachineLICM.cpp

index 72f7d4549c87b2dbc5165ab2ea479cf9f00e2b41..0edd44ba2e555cb8c68808af18f70339bc337784 100644 (file)
@@ -247,6 +247,8 @@ void MachineLICM::HoistRegionPostRA(MachineDomTreeNode *N) {
     if (!CurLoop->contains(BB))
       continue;
     // Conservatively treat live-in's as an external def.
+    // FIXME: That means a reload that's reused into a fallthrough block
+    // will not be LICM'ed.
     for (MachineBasicBlock::const_livein_iterator I = BB->livein_begin(),
            E = BB->livein_end(); I != E; ++I) {
       unsigned Reg = *I;
@@ -282,7 +284,8 @@ void MachineLICM::HoistRegionPostRA(MachineDomTreeNode *N) {
         }
       }
 
-      // FIXME: Only consider reloads for now.
+      // FIXME: Only consider reloads for now. We should be able to handle
+      // remat which does not have register operands.
       bool SkipCheck = false;
       int FI;
       if (SeenDef && !RuledOut) {