Give PassManager and FunctionPassManager a common base class, with

add(Pass *) as a pure virtual member function. This will allow all
the various addPassesTo* functions in LLVM to avoid hard-coding what
type of PassManager is used.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@48226 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/llvm/PassManager.h b/include/llvm/PassManager.h
index 6d462026e3a25c02a48c0e6dd75e359cdffba81a..294b8453015a815637c1192b81e61f19565912cd 100644 (file)
--- a/include/llvm/PassManager.h
+++ b/include/llvm/PassManager.h
@@ -29,8 +29,22 @@ class ModuleProvider;
 class PassManagerImpl;
 class FunctionPassManagerImpl;
 
+/// PassManagerBase - An abstract interface to allow code to add passes to
+/// a pass manager without having to hard-code what kind of pass manager
+/// it is.
+class PassManagerBase {
+public:
+  virtual ~PassManagerBase();
+
+  /// add - Add a pass to the queue of passes to run.  This passes ownership of
+  /// the Pass to the PassManager.  When the PassManager is destroyed, the pass
+  /// will be destroyed as well, so there is no need to delete the pass.  This
+  /// implies that all passes MUST be allocated with 'new'.
+  virtual void add(Pass *P) = 0;
+};
+
 /// PassManager manages ModulePassManagers
-class PassManager {
+class PassManager : public PassManagerBase {
 public:
 
   PassManager();
@@ -54,7 +68,7 @@ private:
 };
 
 /// FunctionPassManager manages FunctionPasses and BasicBlockPassManagers.
-class FunctionPassManager {
+class FunctionPassManager : public PassManagerBase {
 public:
   /// FunctionPassManager ctor - This initializes the pass manager.  It needs,
   /// but does not take ownership of, the specified module provider.

diff --git a/lib/VMCore/PassManager.cpp b/lib/VMCore/PassManager.cpp
index 16966452e1b2e180e35bf3aeb6f32b76a5b6fca8..bef1171bd0e4165d9df37e3c05721c702270e833 100644 (file)
--- a/lib/VMCore/PassManager.cpp
+++ b/lib/VMCore/PassManager.cpp
@@ -1531,4 +1531,4 @@ void BasicBlockPass::assignPassManager(PMStack &PMS,
   BBP->add(this);
 }
 
-
+PassManagerBase::~PassManagerBase() {}