Before deleting a basic block, give other loop passes a chance cleanup analysis value...
authorDevang Patel <dpatel@apple.com>
Wed, 25 Mar 2009 23:57:48 +0000 (23:57 +0000)
committerDevang Patel <dpatel@apple.com>
Wed, 25 Mar 2009 23:57:48 +0000 (23:57 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@67719 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Analysis/LoopPass.cpp
lib/Transforms/Scalar/LoopIndexSplit.cpp
test/Transforms/LICM/2009-03-25-AliasSetTracker.ll [new file with mode: 0644]

index c4ff9889446da81dc5bdeb2b32e277b83e0916fa..08c25f4ceae478aaf90c9523cf87d7f7424dd722 100644 (file)
@@ -152,6 +152,13 @@ void LPPassManager::cloneBasicBlockSimpleAnalysis(BasicBlock *From,
 
 /// deleteSimpleAnalysisValue - Invoke deleteAnalysisValue hook for all passes.
 void LPPassManager::deleteSimpleAnalysisValue(Value *V, Loop *L) {
+  if (BasicBlock *BB = dyn_cast<BasicBlock>(V)) {
+    for (BasicBlock::iterator BI = BB->begin(), BE = BB->end(); BI != BE; 
+         ++BI) {
+      Instruction &I = *BI;
+      deleteSimpleAnalysisValue(&I, L);
+    }
+  }
   for (unsigned Index = 0; Index < getNumContainedPasses(); ++Index) {  
     Pass *P = getContainedPass(Index);
     LoopPass *LP = dynamic_cast<LoopPass *>(P);
index e93d448cc1be826f5f71310d89aacfd3b56a8880..98e5cc15d6c91a564d01cae1ab06a38a2d359844 100644 (file)
@@ -673,6 +673,7 @@ void LoopIndexSplit::removeBlocks(BasicBlock *DeadBB, Loop *LP,
 
   while (!WorkList.empty()) {
     BasicBlock *BB = WorkList.back(); WorkList.pop_back();
+    LPM->deleteSimpleAnalysisValue(BB, LP);
     for(BasicBlock::iterator BBI = BB->begin(), BBE = BB->end(); 
         BBI != BBE; ) {
       Instruction *I = BBI;
@@ -680,7 +681,6 @@ void LoopIndexSplit::removeBlocks(BasicBlock *DeadBB, Loop *LP,
       I->replaceAllUsesWith(UndefValue::get(I->getType()));
       I->eraseFromParent();
     }
-    LPM->deleteSimpleAnalysisValue(BB, LP);
     DT->eraseNode(BB);
     DF->removeBlock(BB);
     LI->removeBlock(BB);
diff --git a/test/Transforms/LICM/2009-03-25-AliasSetTracker.ll b/test/Transforms/LICM/2009-03-25-AliasSetTracker.ll
new file mode 100644 (file)
index 0000000..c3c9a81
--- /dev/null
@@ -0,0 +1,39 @@
+
+; RUN: llvm-as < %s | opt -licm -loop-index-split -instcombine -disable-output
+
+       %struct.FILE = type { i32, i8*, i8*, i8*, i8*, i8*, i8*, i8*, i8*, i8*, i8*, i8*, %struct._IO_marker*, %struct.FILE*, i32, i32, i32, i16, i8, [1 x i8], i8*, i64, i8*, i8*, i8*, i8*, i32, i32, [40 x i8] }
+       %struct._IO_marker = type { %struct._IO_marker*, %struct.FILE*, i32 }
+@"\01LC81" = external constant [4 x i8]                ; <[4 x i8]*> [#uses=1]
+
+define fastcc void @hex_dump_internal(i8* %avcl, %struct.FILE* %f, i32 %level, i8* nocapture %buf, i32 %size) nounwind {
+entry:
+       br i1 false, label %bb4, label %return
+
+bb4:           ; preds = %bb30, %entry
+       br label %bb6
+
+bb6:           ; preds = %bb15, %bb4
+       %j.0.reg2mem.0 = phi i32 [ %2, %bb15 ], [ 0, %bb4 ]             ; <i32> [#uses=2]
+       %0 = icmp slt i32 %j.0.reg2mem.0, 0             ; <i1> [#uses=1]
+       br i1 %0, label %bb7, label %bb13
+
+bb7:           ; preds = %bb6
+       br label %bb15
+
+bb13:          ; preds = %bb6
+       %1 = tail call i32 @fwrite(i8* getelementptr ([4 x i8]* @"\01LC81", i32 0, i32 0), i32 1, i32 3, i8* null) nounwind             ; <i32> [#uses=0]
+       br label %bb15
+
+bb15:          ; preds = %bb13, %bb7
+       %2 = add i32 %j.0.reg2mem.0, 1          ; <i32> [#uses=2]
+       %3 = icmp sgt i32 %2, 15                ; <i1> [#uses=1]
+       br i1 %3, label %bb30, label %bb6
+
+bb30:          ; preds = %bb15
+       br i1 false, label %bb4, label %return
+
+return:                ; preds = %bb30, %entry
+       ret void
+}
+
+declare i32 @fwrite(i8* nocapture, i32, i32, i8* nocapture) nounwind