tools: inline simple single-use function
authorSaleem Abdulrasool <compnerd@compnerd.org>
Sun, 25 May 2014 20:26:40 +0000 (20:26 +0000)
committerSaleem Abdulrasool <compnerd@compnerd.org>
Sun, 25 May 2014 20:26:40 +0000 (20:26 +0000)
This inlines the single use function in preparation for splitting the Win64EH
printing out of the COFFDumper into its own entity.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@209605 91177308-0d34-0410-b5e6-96231b3b80d8

tools/llvm-readobj/COFFDumper.cpp

index 9f00fe1984d57f5d61b6f6a52b162a7b7153c64e..1a360f5bed0129481331dbd8285cfb2dab9c6ffd 100644 (file)
@@ -171,22 +171,6 @@ static unsigned getNumUsedSlots(const UnwindCode &UnwindCode) {
   }
 }
 
-// Given a symbol sym this functions returns the address and section of it.
-static error_code resolveSectionAndAddress(const COFFObjectFile *Obj,
-                                           const SymbolRef &Sym,
-                                           const coff_section *&ResolvedSection,
-                                           uint64_t &ResolvedAddr) {
-  if (error_code EC = Sym.getAddress(ResolvedAddr))
-    return EC;
-
-  section_iterator iter(Obj->section_begin());
-  if (error_code EC = Sym.getSection(iter))
-    return EC;
-
-  ResolvedSection = Obj->getCOFFSection(*iter);
-  return object_error::success;
-}
-
 // Given a a section and an offset into this section the function returns the
 // symbol used for the relocation at the offset.
 error_code COFFDumper::resolveSymbol(const coff_section *Section,
@@ -471,10 +455,14 @@ error_code COFFDumper::resolveRelocation(const coff_section *Section,
   if (error_code EC = resolveSymbol(Section, Offset, Sym))
     return EC;
 
-  if (error_code EC = resolveSectionAndAddress(Obj, Sym, ResolvedSection,
-                                               ResolvedAddress))
+  if (error_code EC = Sym.getAddress(ResolvedAddr))
+    return EC;
+
+  section_iterator SI(Obj->section_begin());
+  if (error_code EC = Sym.getSection(SI))
     return EC;
 
+  ResolvedSection = Obj->getCOFFSection(*SI);
   return object_error::success;
 }