Adjust loop per review feedback.
authorDale Johannesen <dalej@apple.com>
Wed, 30 Jan 2008 19:44:39 +0000 (19:44 +0000)
committerDale Johannesen <dalej@apple.com>
Wed, 30 Jan 2008 19:44:39 +0000 (19:44 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46569 91177308-0d34-0410-b5e6-96231b3b80d8

lib/CodeGen/MachineModuleInfo.cpp

index c1823947b1dcca9da6c82864277ffe159805632e..80bedd0ad7f57fbdd510119c1f11390550bc2ab5 100644 (file)
@@ -106,8 +106,7 @@ static GlobalVariable *getGlobalVariable(Value *V) {
       return dyn_cast<GlobalVariable>(CE->getOperand(0));
     } else if (CE->getOpcode() == Instruction::GetElementPtr) {
       for (unsigned int i=1; i<CE->getNumOperands(); i++) {
-        Constant* CI = cast<Constant>(CE->getOperand(i));
-        if (!CI || !CI->isNullValue())
+        if (!CE->getOperand(i)->isNullValue())
           return NULL;
       }
       return dyn_cast<GlobalVariable>(CE->getOperand(0));
@@ -126,8 +125,7 @@ static bool isGlobalVariable(Value *V) {
       return isa<GlobalVariable>(CE->getOperand(0));
     } else if (CE->getOpcode() == Instruction::GetElementPtr) {
       for (unsigned int i=1; i<CE->getNumOperands(); i++) {
-        Constant* CI = cast<Constant>(CE->getOperand(i));
-        if (!CI || !CI->isNullValue())
+        if (!CE->getOperand(i)->isNullValue())
           return false;
       }
       return isa<GlobalVariable>(CE->getOperand(0));