Give DwarfPrinter a protected (but not virtual) destructor. Cppcheck
authorDuncan Sands <baldrick@free.fr>
Sun, 7 Feb 2010 21:09:22 +0000 (21:09 +0000)
committerDuncan Sands <baldrick@free.fr>
Sun, 7 Feb 2010 21:09:22 +0000 (21:09 +0000)
warns about this base class not having a virtual destructor, but since
this class has no virtual methods and neither it or the types derived
from it has a destructor, a protected trivial destructor will do (and
shuts cppcheck up) the trick without the cost of introducing a vtable.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@95526 91177308-0d34-0410-b5e6-96231b3b80d8

lib/CodeGen/AsmPrinter/DwarfPrinter.h

index 19d08e28cdb7d7969fd48edf40ac6f7d2c0a38da..69d9c27ff0b09e94a3ae15d2feec2a91c258ed19 100644 (file)
@@ -33,6 +33,8 @@ class Twine;
 
 class DwarfPrinter {
 protected:
+  ~DwarfPrinter() {}
+
   //===-------------------------------------------------------------==---===//
   // Core attributes used by the DWARF printer.
   //