[tsan] typo and style (thanks to Nick Lewycky)
authorKostya Serebryany <kcc@google.com>
Wed, 2 May 2012 13:12:19 +0000 (13:12 +0000)
committerKostya Serebryany <kcc@google.com>
Wed, 2 May 2012 13:12:19 +0000 (13:12 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@155986 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Transforms/Instrumentation/ThreadSanitizer.cpp

index 2f6c829e890344f66eb745802337c045afec78cd..31af145e79b00b140f1ef11fb2b42c47270ea74b 100644 (file)
@@ -71,8 +71,8 @@ struct ThreadSanitizer : public FunctionPass {
  private:
   bool instrumentLoadOrStore(Instruction *I);
   bool instrumentAtomic(Instruction *I);
-  void choseInstructionsToInstrument(SmallVectorImpl<Instruction*> &Local,
-                                     SmallVectorImpl<Instruction*> &All);
+  void chooseInstructionsToInstrument(SmallVectorImpl<Instruction*> &Local,
+                                      SmallVectorImpl<Instruction*> &All);
   bool addrPointsToConstantData(Value *Addr);
   int getMemoryAccessFuncIndex(Value *Addr);
 
@@ -207,7 +207,7 @@ bool ThreadSanitizer::addrPointsToConstantData(Value *Addr) {
 //
 // 'Local' is a vector of insns within the same BB (no calls between).
 // 'All' is a vector of insns that will be instrumented.
-void ThreadSanitizer::choseInstructionsToInstrument(
+void ThreadSanitizer::chooseInstructionsToInstrument(
     SmallVectorImpl<Instruction*> &Local,
     SmallVectorImpl<Instruction*> &All) {
   SmallSet<Value*, 8> WriteTargets;
@@ -238,13 +238,13 @@ void ThreadSanitizer::choseInstructionsToInstrument(
 static bool isAtomic(Instruction *I) {
   if (LoadInst *LI = dyn_cast<LoadInst>(I))
     return LI->isAtomic() && LI->getSynchScope() == CrossThread;
-  else if (StoreInst *SI = dyn_cast<StoreInst>(I))
+  if (StoreInst *SI = dyn_cast<StoreInst>(I))
     return SI->isAtomic() && SI->getSynchScope() == CrossThread;
-  else if (isa<AtomicRMWInst>(I))
+  if (isa<AtomicRMWInst>(I))
     return true;
-  else if (isa<AtomicCmpXchgInst>(I))
+  if (isa<AtomicCmpXchgInst>(I))
     return true;
-  else if (FenceInst *FI = dyn_cast<FenceInst>(I))
+  if (FenceInst *FI = dyn_cast<FenceInst>(I))
     return FI->getSynchScope() == CrossThread;
   return false;
 }
@@ -273,10 +273,10 @@ bool ThreadSanitizer::runOnFunction(Function &F) {
         RetVec.push_back(BI);
       else if (isa<CallInst>(BI) || isa<InvokeInst>(BI)) {
         HasCalls = true;
-        choseInstructionsToInstrument(LocalLoadsAndStores, AllLoadsAndStores);
+        chooseInstructionsToInstrument(LocalLoadsAndStores, AllLoadsAndStores);
       }
     }
-    choseInstructionsToInstrument(LocalLoadsAndStores, AllLoadsAndStores);
+    chooseInstructionsToInstrument(LocalLoadsAndStores, AllLoadsAndStores);
   }
 
   // We have collected all loads and stores.