Cleanup a few magic numbers.
authorChad Rosier <mcrosier@apple.com>
Wed, 5 Sep 2012 22:40:13 +0000 (22:40 +0000)
committerChad Rosier <mcrosier@apple.com>
Wed, 5 Sep 2012 22:40:13 +0000 (22:40 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@163263 91177308-0d34-0410-b5e6-96231b3b80d8

include/llvm/InlineAsm.h
lib/CodeGen/MachineInstr.cpp
lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

index 53ceca551b6fc27b2ff4db385156c9f6a52f6941..a0aecfd8e4700e01ccdb59bd768bcadff6829266 100644 (file)
@@ -214,7 +214,7 @@ public:
     // Interpretation of the MIOp_ExtraInfo bit field.
     Extra_HasSideEffects = 1,
     Extra_IsAlignStack = 2,
-    Extra_AsmDialect = 3,
+    Extra_AsmDialect = 4,
 
     // Inline asm operands map to multiple SDNode / MachineInstr operands.
     // The first operand is an immediate describing the asm operand, the low
index 362d99a8a45a29499593e3f9d4989cddeb6d5396..e40aee5b20084e93212f930632f98ed5c4b497fc 100644 (file)
@@ -970,7 +970,7 @@ bool MachineInstr::isStackAligningInlineAsm() const {
 InlineAsm::AsmDialect MachineInstr::getInlineAsmDialect() const {
   assert(isInlineAsm() && "getInlineAsmDialect() only works for inline asms!");
   unsigned ExtraInfo = getOperand(InlineAsm::MIOp_ExtraInfo).getImm();
-  return InlineAsm::AsmDialect((ExtraInfo >> 2) & 1);
+  return InlineAsm::AsmDialect((ExtraInfo & InlineAsm::Extra_AsmDialect) != 0);
 }
 
 int MachineInstr::findInlineAsmFlagIdx(unsigned OpIdx,
index d81c376fe129fb3bc6e19a6109a5dfc7df5f92fd..31d633c89b484ccc5b72f48da4fa380593a5846c 100644 (file)
@@ -6085,7 +6085,7 @@ void SelectionDAGBuilder::visitInlineAsm(ImmutableCallSite CS) {
   if (IA->isAlignStack())
     ExtraInfo |= InlineAsm::Extra_IsAlignStack;
   // Set the asm dialect.
-  ExtraInfo |= IA->getDialect() << 2;
+  ExtraInfo |= IA->getDialect() * InlineAsm::Extra_AsmDialect;
   AsmNodeOperands.push_back(DAG.getTargetConstant(ExtraInfo,
                                                   TLI.getPointerTy()));