The r128085 checkin modified the operand ordering for MRC/MRC2 instructions.

Modify DisassembleCoprocessor() of ARMDisassemblerCore.cpp to react to the change.

rdar://problem/9236873

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@128922 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Target/ARM/Disassembler/ARMDisassemblerCore.cpp b/lib/Target/ARM/Disassembler/ARMDisassemblerCore.cpp
index cc7f0d6e60ce47eab0fd4e3544a2a459317322d4..9ba4a8d624592f1e1471437b6716efd2aa172639 100644 (file)
--- a/lib/Target/ARM/Disassembler/ARMDisassemblerCore.cpp
+++ b/lib/Target/ARM/Disassembler/ARMDisassemblerCore.cpp
@@ -681,10 +681,17 @@ static bool DisassembleCoprocessor(MCInst &MI, unsigned Opcode, uint32_t insn,
   // CDP/CDP2 has no GPR operand; the opc1 operand is also wider (Inst{23-20}).
   bool NoGPR = (Opcode == ARM::CDP || Opcode == ARM::CDP2);
   bool LdStCop = LdStCopOpcode(Opcode);
   // CDP/CDP2 has no GPR operand; the opc1 operand is also wider (Inst{23-20}).
   bool NoGPR = (Opcode == ARM::CDP || Opcode == ARM::CDP2);
   bool LdStCop = LdStCopOpcode(Opcode);

+  bool RtOut = (Opcode == ARM::MRC || Opcode == ARM::MRC2);

 
   OpIdx = 0;
 
 
   OpIdx = 0;
 

+  if (RtOut) {
+    MI.addOperand(MCOperand::CreateReg(getRegisterEnum(B, ARM::GPRRegClassID,
+                                                       decodeRd(insn))));
+    ++OpIdx;
+  }

   MI.addOperand(MCOperand::CreateImm(GetCoprocessor(insn)));
   MI.addOperand(MCOperand::CreateImm(GetCoprocessor(insn)));

+  ++OpIdx;

 
   if (LdStCop) {
     // Unindex if P:W = 0b00 --> _OPTION variant
 
   if (LdStCop) {
     // Unindex if P:W = 0b00 --> _OPTION variant


@@ -694,6 +701,7 @@ static bool DisassembleCoprocessor(MCInst &MI, unsigned Opcode, uint32_t insn,
 
     MI.addOperand(MCOperand::CreateReg(getRegisterEnum(B, ARM::GPRRegClassID,
                                                        decodeRn(insn))));
 
     MI.addOperand(MCOperand::CreateReg(getRegisterEnum(B, ARM::GPRRegClassID,
                                                        decodeRn(insn))));

+    OpIdx += 2;

 
     if (PW) {
       MI.addOperand(MCOperand::CreateReg(0));
 
     if (PW) {
       MI.addOperand(MCOperand::CreateReg(0));


@@ -704,19 +712,23 @@ static bool DisassembleCoprocessor(MCInst &MI, unsigned Opcode, uint32_t insn,
       unsigned Offset = ARM_AM::getAM2Opc(AddrOpcode, slice(insn, 7, 0) << 2,
                                           ARM_AM::no_shift, IndexMode);
       MI.addOperand(MCOperand::CreateImm(Offset));
       unsigned Offset = ARM_AM::getAM2Opc(AddrOpcode, slice(insn, 7, 0) << 2,
                                           ARM_AM::no_shift, IndexMode);
       MI.addOperand(MCOperand::CreateImm(Offset));

-      OpIdx = 5;
+      OpIdx += 2;

     } else {
       MI.addOperand(MCOperand::CreateImm(slice(insn, 7, 0)));
     } else {
       MI.addOperand(MCOperand::CreateImm(slice(insn, 7, 0)));

-      OpIdx = 4;
+      ++OpIdx;

     }
   } else {
     MI.addOperand(MCOperand::CreateImm(OneCopOpc ? GetCopOpc(insn)
                                                  : GetCopOpc1(insn, NoGPR)));
     }
   } else {
     MI.addOperand(MCOperand::CreateImm(OneCopOpc ? GetCopOpc(insn)
                                                  : GetCopOpc1(insn, NoGPR)));

+    ++OpIdx;

 
 

-    MI.addOperand(NoGPR ? MCOperand::CreateImm(decodeRd(insn))
-                        : MCOperand::CreateReg(
-                            getRegisterEnum(B, ARM::GPRRegClassID,
-                                            decodeRd(insn))));
+    if (!RtOut) {
+      MI.addOperand(NoGPR ? MCOperand::CreateImm(decodeRd(insn))
+                          : MCOperand::CreateReg(
+                                getRegisterEnum(B, ARM::GPRRegClassID,
+                                                decodeRd(insn))));
+      ++OpIdx;
+    }

 
     MI.addOperand(OneCopOpc ? MCOperand::CreateReg(
                                 getRegisterEnum(B, ARM::GPRRegClassID,
 
     MI.addOperand(OneCopOpc ? MCOperand::CreateReg(
                                 getRegisterEnum(B, ARM::GPRRegClassID,


@@ -725,7 +737,7 @@ static bool DisassembleCoprocessor(MCInst &MI, unsigned Opcode, uint32_t insn,
 
     MI.addOperand(MCOperand::CreateImm(decodeRm(insn)));
 
 
     MI.addOperand(MCOperand::CreateImm(decodeRm(insn)));
 

-    OpIdx = 5;
+    OpIdx += 2;

 
     if (!OneCopOpc) {
       MI.addOperand(MCOperand::CreateImm(GetCopOpc2(insn)));
 
     if (!OneCopOpc) {
       MI.addOperand(MCOperand::CreateImm(GetCopOpc2(insn)));

diff --git a/test/MC/Disassembler/ARM/arm-tests.txt b/test/MC/Disassembler/ARM/arm-tests.txt
index 00f682e5361923e62c0aa80f7ad8e77389e82661..084fc8b82c9fc4dc4fc867fbbdb44d5314b9f9bc 100644 (file)
--- a/test/MC/Disassembler/ARM/arm-tests.txt
+++ b/test/MC/Disassembler/ARM/arm-tests.txt
@@ -236,3 +236,6 @@
 
 # CHECK:       streq   r1, [sp], #-1567
 0x1f 0x16 0xd 0x4
 
 # CHECK:       streq   r1, [sp], #-1567
 0x1f 0x16 0xd 0x4

+
+# CHECK:       mrchs   p2, #3, r11, c13, c6, #6
+0xd6 0xb2 0x7d 0x2e