[cmake] Attempt to fix sanitizer buildbot.
authorQuentin Colombet <qcolombet@apple.com>
Thu, 16 Jan 2014 06:43:55 +0000 (06:43 +0000)
committerQuentin Colombet <qcolombet@apple.com>
Thu, 16 Jan 2014 06:43:55 +0000 (06:43 +0000)
The generation of the native_export_file end up in
several different makefiles. All those makefiles
write the same file, but can be executed concurrently...
and bad things happen!

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199356 91177308-0d34-0410-b5e6-96231b3b80d8

cmake/modules/AddLLVM.cmake

index de00ab46ae9a6543cd1ebcaad6aa7b32824b4c63..e93ea10089bd26acd4891ecac14c3ead7dbd77fc 100644 (file)
@@ -85,8 +85,12 @@ function(add_llvm_symbol_exports target_name export_file)
   # Force re-linking when the exports file changes. Actually, it
   # forces recompilation of the source file. The LINK_DEPENDS target
   # property only works for makefile-based generators.
-  set_property(SOURCE ${first_source_file} APPEND PROPERTY
-    OBJECT_DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/${native_export_file})
+  # FIXME: This is not safe because this will create the same target
+  # ${native_export_file} in several different file:
+  # - One where we emitted ${target_name}_exports
+  # - One where we emitted the build command for the following object.
+  # set_property(SOURCE ${first_source_file} APPEND PROPERTY
+  #   OBJECT_DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/${native_export_file})
 
   set_property(DIRECTORY APPEND
     PROPERTY ADDITIONAL_MAKE_CLEAN_FILES ${native_export_file})