Eliminate AsmPrinter::EmitExternalGlobal, inlining its (now)

one implementation into its one caller.  This eliminates a totally
awesome and gratuitous hack where we casted a Function* to
GlobalVariable*.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@81967 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/llvm/CodeGen/AsmPrinter.h b/include/llvm/CodeGen/AsmPrinter.h
index 8404841b5a3f70ebadced0ec98b6b78f536f0249..375b260c135e73b69d7f2120b1a42074944e18cf 100644 (file)
--- a/include/llvm/CodeGen/AsmPrinter.h
+++ b/include/llvm/CodeGen/AsmPrinter.h
@@ -159,10 +159,6 @@ namespace llvm {
     ///
     bool isVerbose() const { return VerboseAsm; }
 
-    /// EmitExternalGlobal - Emit the external reference to a global variable.
-    /// Should be overridden if an indirect reference should be used.
-    virtual void EmitExternalGlobal(const GlobalVariable *GV);
-
     /// getCurrentFunctionEHName - Called to return the CurrentFnEHName.
     /// 
     std::string getCurrentFunctionEHName(const MachineFunction *MF) const;

diff --git a/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
index a457421b90711b01732a86452e54eb637482ebc9..e5f0dba2b97e534895c8c941d1d16ac474a0db99 100644 (file)
--- a/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
+++ b/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
@@ -509,13 +509,6 @@ void AsmPrinter::EmitXXStructorList(Constant *List) {
     }
 }
 
-/// EmitExternalGlobal - Emit the external reference to a global variable.
-/// Should be overridden if an indirect reference should be used.
-void AsmPrinter::EmitExternalGlobal(const GlobalVariable *GV) {
-  O << Mang->getMangledName(GV);
-}
-
-
 
 //===----------------------------------------------------------------------===//
 /// LEB 128 number encoding.

diff --git a/lib/CodeGen/AsmPrinter/DwarfException.cpp b/lib/CodeGen/AsmPrinter/DwarfException.cpp
index abd2e6fe80d30bb80fda99a3ea772f5cd689d0f7..f8e8009cd0c9727f32881dcdc4f7dc9822bb7489 100644 (file)
--- a/lib/CodeGen/AsmPrinter/DwarfException.cpp
+++ b/lib/CodeGen/AsmPrinter/DwarfException.cpp
@@ -163,7 +163,7 @@ void DwarfException::EmitCIE(const Function *Personality, unsigned Index) {
     O << MAI->getData32bitsDirective();
     
     O << MAI->getPersonalityPrefix();
-    Asm->EmitExternalGlobal((const GlobalVariable *)(Personality));
+    O << Asm->Mang->getMangledName(Personality);
     O << MAI->getPersonalitySuffix();
     
     if (strcmp(MAI->getPersonalitySuffix(), "+4@GOTPCREL"))