SLPVectorizer: AllSameOpcode* starts "true" only for instructions
authorMehdi Amini <mehdi.amini@apple.com>
Fri, 23 Oct 2015 01:04:45 +0000 (01:04 +0000)
committerMehdi Amini <mehdi.amini@apple.com>
Fri, 23 Oct 2015 01:04:45 +0000 (01:04 +0000)
r251085 wasn't as NFC as intended...

From: Mehdi Amini <mehdi.amini@apple.com>

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251087 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Transforms/Vectorize/SLPVectorizer.cpp

index 0930d580363e84022629632d9bda75194f728348..57b09caa5a4436036b260e51608080e77078d022 100644 (file)
@@ -2002,9 +2002,6 @@ void BoUpSLP::reorderInputsAccordingToOpcode(ArrayRef<Value *> VL,
 
   SmallVector<Value *, 16> OrigLeft, OrigRight;
 
-  bool AllSameOpcodeLeft = true;
-  bool AllSameOpcodeRight = true;
-
   if (VL.size()) {
     // Peel the first iteration out of the loop since there's nothing
     // interesting to do anyway and it simplifies the checks
@@ -2019,6 +2016,10 @@ void BoUpSLP::reorderInputsAccordingToOpcode(ArrayRef<Value *> VL,
     Right.push_back(VRight);
   }
 
+  // Keep track if we have instructions with all the same opcode on one side.
+  bool AllSameOpcodeLeft = isa<Instruction>(Left[0]);
+  bool AllSameOpcodeRight = isa<Instruction>(Right[0]);
+
   for (unsigned i = 1, e = VL.size(); i != e; ++i) {
     Instruction *I = cast<Instruction>(VL[i]);