Changes to fix buffering that I forgot to commit with previous patch.
authorChris Lattner <sabre@nondot.org>
Fri, 22 Jan 2010 21:16:10 +0000 (21:16 +0000)
committerChris Lattner <sabre@nondot.org>
Fri, 22 Jan 2010 21:16:10 +0000 (21:16 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@94222 91177308-0d34-0410-b5e6-96231b3b80d8

include/llvm/Support/raw_ostream.h
lib/MC/MCAsmStreamer.cpp
lib/Support/raw_ostream.cpp

index 05794e5898878c13012ffa4991396d575b75b7d9..0f227ccc3f803bc7af39eee102dc4bf02c3badd1 100644 (file)
@@ -456,8 +456,10 @@ public:
   explicit raw_svector_ostream(SmallVectorImpl<char> &O);
   ~raw_svector_ostream();
 
-  /// clear - Flush the stream and clear the underlying vector.
-  void clear();
+  /// resync - This is called when the SmallVector we're appending to is changed
+  /// outside of the raw_svector_ostream's control.  It is only safe to do this
+  /// if the raw_svector_ostream has previously been flushed.
+  void resync();
   
   /// str - Flushes the stream contents to the target vector and return a
   /// StringRef for the vector contents.
index e284e15bca22a6a6ebcc651ad3466fae3e84cfc7..d4ef3ca826cad5f1ad8009c5f551bc656c1fd5e8 100644 (file)
@@ -136,6 +136,9 @@ void MCAsmStreamer::AddComment(const Twine &T) {
   T.toVector(CommentToEmit);
   // Each comment goes on its own line.
   CommentToEmit.push_back('\n');
+  
+  // Tell the comment stream that the vector changed underneath it.
+  CommentStream.resync();
 }
 
 void MCAsmStreamer::EmitCommentsAndEOL() {
@@ -158,7 +161,9 @@ void MCAsmStreamer::EmitCommentsAndEOL() {
     Comments = Comments.substr(Position+1);
   } while (!Comments.empty());
   
-  CommentStream.clear();
+  CommentToEmit.clear();
+  // Tell the comment stream that the vector changed underneath it.
+  CommentStream.resync();
 }
 
 
index 7cd16c888b9ec7e4f156db2cdb3eb41e690ad6c1..10d7ec0701272d4bf3cbf815b503f7715537e917 100644 (file)
@@ -562,11 +562,14 @@ raw_svector_ostream::~raw_svector_ostream() {
   flush();
 }
 
-/// clear - Flush the stream and clear the underlying vector.
-void raw_svector_ostream::clear() {
-  if (GetNumBytesInBuffer() == 0) flush();
-  
-  OS.clear();
+/// resync - This is called when the SmallVector we're appending to is changed
+/// outside of the raw_svector_ostream's control.  It is only safe to do this
+/// if the raw_svector_ostream has previously been flushed.
+void raw_svector_ostream::resync() {
+  assert(GetNumBytesInBuffer() == 0 && "Didn't flush before mutating vector");
+
+  if (OS.capacity() - OS.size() < 64)
+    OS.reserve(OS.capacity() * 2);
   SetBuffer(OS.end(), OS.capacity() - OS.size());
 }