Revert "Allow modifying an ImmutableMap without canonicalizing it immediately."
authorTed Kremenek <kremenek@apple.com>
Thu, 6 Dec 2012 19:41:30 +0000 (19:41 +0000)
committerTed Kremenek <kremenek@apple.com>
Thu, 6 Dec 2012 19:41:30 +0000 (19:41 +0000)
Jordan and I discussed this, and we don't want this in the API.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@169541 91177308-0d34-0410-b5e6-96231b3b80d8

include/llvm/ADT/ImmutableMap.h

index 0043dc6f000017affb18b698a6651a7f61c99d56..4883c5ba0a6b0e2e56fcd3eb0601914127826aaf 100644 (file)
@@ -96,40 +96,27 @@ public:
 
   class Factory {
     typename TreeTy::Factory F;
-    const bool Canonicalizing;
+    const bool Canonicalize;
 
   public:
     Factory(bool canonicalize = true)
-      : Canonicalizing(canonicalize) {}
+      : Canonicalize(canonicalize) {}
     
     Factory(BumpPtrAllocator& Alloc, bool canonicalize = true)
-      : F(Alloc), Canonicalizing(canonicalize) {}
+      : F(Alloc), Canonicalize(canonicalize) {}
 
     ImmutableMap getEmptyMap() { return ImmutableMap(F.getEmptyTree()); }
 
-    ImmutableMap add(ImmutableMap Old, key_type_ref K, data_type_ref D,
-                     bool Canonicalize) {
+    ImmutableMap add(ImmutableMap Old, key_type_ref K, data_type_ref D) {
       TreeTy *T = F.add(Old.Root, std::pair<key_type,data_type>(K,D));
       return ImmutableMap(Canonicalize ? F.getCanonicalTree(T): T);
     }
 
-    ImmutableMap add(ImmutableMap Old, key_type_ref K, data_type_ref D) {
-      return add(Old, K, D, Canonicalizing);
-    }
-
-    ImmutableMap remove(ImmutableMap Old, key_type_ref K, bool Canonicalize) {
+    ImmutableMap remove(ImmutableMap Old, key_type_ref K) {
       TreeTy *T = F.remove(Old.Root,K);
       return ImmutableMap(Canonicalize ? F.getCanonicalTree(T): T);
     }
 
-    ImmutableMap remove(ImmutableMap Old, key_type_ref K) {
-      return remove(Old, K, Canonicalizing);
-    }
-
-    ImmutableMap getCanonicalMap(ImmutableMap Map) {
-      return ImmutableMap(F.getCanonicalTree(Map.Root));
-    }
-
     typename TreeTy::Factory *getTreeFactory() const {
       return const_cast<typename TreeTy::Factory *>(&F);
     }