Use fixed-point representation for BranchProbability.
authorCong Hou <congh@google.com>
Fri, 25 Sep 2015 23:09:59 +0000 (23:09 +0000)
committerCong Hou <congh@google.com>
Fri, 25 Sep 2015 23:09:59 +0000 (23:09 +0000)
commitfed6bd86172fe5286db1aba61998f42ebaefd9f3
tree0a53f096c67f8964fd2598e8aa2b4cb28ec469f1
parent014636709b212e93f67c4d9d9844325adbf7b1eb
Use fixed-point representation for BranchProbability.

BranchProbability now is represented by its numerator and denominator in uint32_t type. This patch changes this representation into a fixed point that is represented by the numerator in uint32_t type and a constant denominator 1<<31. This is quite similar to the representation of BlockMass in BlockFrequencyInfoImpl.h. There are several pros and cons of this change:

Pros:

1. It uses only a half space of the current one.
2. Some operations are much faster like plus, subtraction, comparison, and scaling by an integer.

Cons:

1. Constructing a probability using arbitrary numerator and denominator needs additional calculations.
2. It is a little less precise than before as we use a fixed denominator. For example, 1 - 1/3 may not be exactly identical to 1 / 3 (this will lead to many BranchProbability unit test failures). This should not matter when we only use it for branch probability. If we use it like a rational value for some precise calculations we may need another construct like ValueRatio.

One important reason for this change is that we propose to store branch probabilities instead of edge weights in MachineBasicBlock. We also want clients to use probability instead of weight when adding successors to a MBB. The current BranchProbability has more space which may be a concern.

Differential revision: http://reviews.llvm.org/D12603

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@248633 91177308-0d34-0410-b5e6-96231b3b80d8
18 files changed:
include/llvm/Analysis/BlockFrequencyInfoImpl.h
include/llvm/Support/BranchProbability.h
lib/Support/BranchProbability.cpp
test/Analysis/BlockFrequencyInfo/basic.ll
test/Analysis/BlockFrequencyInfo/loops_with_profile_info.ll
test/Analysis/BranchProbabilityInfo/basic.ll
test/Analysis/BranchProbabilityInfo/loop.ll
test/Analysis/BranchProbabilityInfo/noreturn.ll
test/Analysis/BranchProbabilityInfo/pr18705.ll
test/Analysis/BranchProbabilityInfo/pr22718.ll
test/CodeGen/AArch64/aarch64-deferred-spilling.ll
test/Transforms/SampleProfile/branch.ll
test/Transforms/SampleProfile/calls.ll
test/Transforms/SampleProfile/discriminator.ll
test/Transforms/SampleProfile/fnptr.ll
test/Transforms/SampleProfile/propagate.ll
unittests/Support/BlockFrequencyTest.cpp
unittests/Support/BranchProbabilityTest.cpp