[Symbolizer] Don't use PE symbol tables to override PDB symbols
authorReid Kleckner <rnk@google.com>
Fri, 13 Nov 2015 17:00:36 +0000 (17:00 +0000)
committerReid Kleckner <rnk@google.com>
Fri, 13 Nov 2015 17:00:36 +0000 (17:00 +0000)
commit84831cda6605dcb4748f66cb727f3739319e77ca
treeea0d7b85806a1dfb11f1ff6f0f60953ac2450c50
parente3049a74d7ecf75a16d9d6f9358d22b251ce546c
[Symbolizer] Don't use PE symbol tables to override PDB symbols

Summary:
PE files are stripped by default, and only contain the names of exported
symbols.

The actual reason that we bother to do this override by default is
actually due to a quirk of the way -gline-tables-only is implemented, so
I phrased the check as "if we are symbolizing from dwarf, do the symtab
override".

This fixes lots of Windows ASan tests that I broke in r250582.

Reviewers: samsonov

Subscribers: llvm-commits

Differential Revision: http://reviews.llvm.org/D14594

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@253051 91177308-0d34-0410-b5e6-96231b3b80d8
lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp
lib/DebugInfo/Symbolize/SymbolizableObjectFile.h