mcs-lock: driver bugfix (deadlocking)
authorBrian Norris <computersforpeace@gmail.com>
Thu, 11 Oct 2012 01:33:27 +0000 (18:33 -0700)
committerBrian Norris <computersforpeace@gmail.com>
Thu, 11 Oct 2012 01:33:27 +0000 (18:33 -0700)
I didn't notice that the guard automatically locks/unlocks the mutex on
creation/destruction, respectively.

mcs-lock/mcs-lock.cc

index a541a2e..26e5a27 100644 (file)
@@ -12,18 +12,14 @@ static uint32_t shared;
 void threadA(void *arg)
 {
        mcs_mutex::guard g(mutex);
-       mutex->lock(&g);
        printf("store: %d\n", 17);
        store_32(&shared, 17);
-       mutex->unlock(&g);
 }
 
 void threadB(void *arg)
 {
        mcs_mutex::guard g(mutex);
-       mutex->lock(&g);
        printf("load: %u\n", load_32(&shared));
-       mutex->unlock(&g);
 }
 
 int user_main(int argc, char **argv)