fix occasional crash in cpu pool

Summary: need to initialize threadsToStop_ and make it signed so it doesn't underflow in rare races

Test Plan: cpu pool unit tests no longer crash if run a ton of times

Reviewed By: davejwatson@fb.com

Subscribers: fugalh, njormrod

FB internal diff: D1563524

diff --git a/folly/experimental/wangle/concurrent/CPUThreadPoolExecutor.h b/folly/experimental/wangle/concurrent/CPUThreadPoolExecutor.h
index 210fd6733d9d02e92dc01070036cdcb6009ff02c..575e23c60d847cdf7e8dd14c450ac9825cdf2f18 100644 (file)
--- a/folly/experimental/wangle/concurrent/CPUThreadPoolExecutor.h
+++ b/folly/experimental/wangle/concurrent/CPUThreadPoolExecutor.h
@@ -53,8 +53,8 @@ class CPUThreadPoolExecutor : public ThreadPoolExecutor {
   void threadRun(ThreadPtr thread) override;
   void stopThreads(size_t n) override;
 
-  std::atomic<size_t> threadsToStop_;
   std::unique_ptr<BlockingQueue<Task>> taskQueue_;
+  std::atomic<ssize_t> threadsToStop_{0};
 };
 
 }} // folly::wangle