Disable SSL socket cache tests if cache isn't available
authorChristopher Dykes <cdykes@fb.com>
Tue, 16 Aug 2016 21:22:59 +0000 (14:22 -0700)
committerFacebook Github Bot 2 <facebook-github-bot-2-bot@fb.com>
Tue, 16 Aug 2016 21:23:31 +0000 (14:23 -0700)
Summary: These tests will always fail if we're building against a version of OpenSSL that doesn't have the extension.

Reviewed By: anirudhvr

Differential Revision: D3724893

fbshipit-source-id: a093d62b9b5ea8239b5d52a66da2a833911b4f47

folly/io/async/test/AsyncSSLSocketTest.cpp

index 386f51ba21265681810d36f2cbdb4c5107949c48..f09a4da4307bf8069e0eddad2992b1cfcf2eac0a 100644 (file)
@@ -878,7 +878,8 @@ TEST(AsyncSSLSocketTest, SSLClientTimeoutTest) {
   cerr << "SSLClientTimeoutTest test completed" << endl;
 }
 
-
+// This is a FB-only extension, and the tests will fail without it
+#ifdef SSL_ERROR_WANT_SESS_CACHE_LOOKUP
 /**
  * Test SSL server async cache
  */
@@ -998,6 +999,7 @@ TEST(AsyncSSLSocketTest, SSLServerCacheCloseTest) {
 
   cerr << "SSLServerCacheCloseTest test completed" << endl;
 }
+#endif
 
 /**
  * Verify Client Ciphers obtained using SSL MSG Callback.