add FOLLY_FALLTHROUGH throughout to satisfy internal linter

Summary: changes as suggested by FB-internal linter

Reviewed By: yfeldblum

Differential Revision: D4957742

fbshipit-source-id: c9d94c477d24f153cab0d25edccfd39ff31fdfdf

diff --git a/folly/Format.cpp b/folly/Format.cpp
index db95ea24088f34aa4c57234cf37b90a76854253e..25ddf6312bdd8f8462c0a2b6f45ba6a386a1d660 100644 (file)
--- a/folly/Format.cpp
+++ b/folly/Format.cpp
@@ -16,6 +16,7 @@
 
 #include <folly/Format.h>
 
+#include <folly/CppAttributes.h>
 #include <folly/portability/Constexpr.h>
 
 #include <double-conversion/double-conversion.h>
@@ -81,6 +82,7 @@ void FormatValue<double>::formatHelper(
   switch (arg.presentation) {
   case '%':
     val *= 100;
+    FOLLY_FALLTHROUGH;
   case 'f':
   case 'F':
     {

diff --git a/folly/SocketAddress.cpp b/folly/SocketAddress.cpp
index ec30b5dee379e186ed631b497a6e57f87a54ccdd..2d12d787e74ae2d4c630b716063a29f9935ad039 100644 (file)
--- a/folly/SocketAddress.cpp
+++ b/folly/SocketAddress.cpp
@@ -20,6 +20,7 @@
 
 #include <folly/SocketAddress.h>
 
+#include <folly/CppAttributes.h>
 #include <folly/Exception.h>
 #include <folly/Hash.h>
 
@@ -554,7 +555,7 @@ bool SocketAddress::prefixMatch(const SocketAddress& other,
   switch (getFamily()) {
     case AF_INET:
       mask_length = 32;
-      // fallthrough
+      FOLLY_FALLTHROUGH;
     case AF_INET6:
     {
       auto prefix = folly::IPAddress::longestCommonPrefix(

diff --git a/folly/SpookyHashV1.cpp b/folly/SpookyHashV1.cpp
index cdd09193a603853daf293b99dc06eca3ca22fbdf..401da9f81a2117bad7e5870533af1d143bfcfdfa 100644 (file)
--- a/folly/SpookyHashV1.cpp
+++ b/folly/SpookyHashV1.cpp
@@ -26,6 +26,8 @@
 
 #include <folly/SpookyHashV1.h>
 
+#include <folly/CppAttributes.h>
+
 #include <cstring>
 
 #define ALLOW_UNALIGNED_READS 1
@@ -96,37 +98,48 @@ void SpookyHashV1::Short(
     switch (remainder)
     {
     case 15:
-    d += ((uint64_t)u.p8[14]) << 48;
+        d += ((uint64_t)u.p8[14]) << 48;
+        FOLLY_FALLTHROUGH;
     case 14:
         d += ((uint64_t)u.p8[13]) << 40;
+        FOLLY_FALLTHROUGH;
     case 13:
         d += ((uint64_t)u.p8[12]) << 32;
+        FOLLY_FALLTHROUGH;
     case 12:
         d += u.p32[2];
         c += u.p64[0];
         break;
     case 11:
         d += ((uint64_t)u.p8[10]) << 16;
+        FOLLY_FALLTHROUGH;
     case 10:
         d += ((uint64_t)u.p8[9]) << 8;
+        FOLLY_FALLTHROUGH;
     case 9:
         d += (uint64_t)u.p8[8];
+        FOLLY_FALLTHROUGH;
     case 8:
         c += u.p64[0];
         break;
     case 7:
         c += ((uint64_t)u.p8[6]) << 48;
+        FOLLY_FALLTHROUGH;
     case 6:
         c += ((uint64_t)u.p8[5]) << 40;
+        FOLLY_FALLTHROUGH;
     case 5:
         c += ((uint64_t)u.p8[4]) << 32;
+        FOLLY_FALLTHROUGH;
     case 4:
         c += u.p32[0];
         break;
     case 3:
         c += ((uint64_t)u.p8[2]) << 16;
+        FOLLY_FALLTHROUGH;
     case 2:
         c += ((uint64_t)u.p8[1]) << 8;
+        FOLLY_FALLTHROUGH;
     case 1:
         c += (uint64_t)u.p8[0];
         break;

diff --git a/folly/SpookyHashV2.cpp b/folly/SpookyHashV2.cpp
index a01271dac4fb83aa4b94b9230bc94ac28d40bc55..0f623625a603f0364c2f82074e1c7f66cec72f18 100644 (file)
--- a/folly/SpookyHashV2.cpp
+++ b/folly/SpookyHashV2.cpp
@@ -28,6 +28,7 @@
 
 #include <folly/SpookyHashV2.h>
 
+#include <folly/CppAttributes.h>
 #include <folly/Portability.h>
 
 #include <cstring>
@@ -98,37 +99,48 @@ void SpookyHashV2::Short(
     switch (remainder)
     {
     case 15:
-    d += ((uint64_t)u.p8[14]) << 48;
+        d += ((uint64_t)u.p8[14]) << 48;
+        FOLLY_FALLTHROUGH;
     case 14:
         d += ((uint64_t)u.p8[13]) << 40;
+        FOLLY_FALLTHROUGH;
     case 13:
         d += ((uint64_t)u.p8[12]) << 32;
+        FOLLY_FALLTHROUGH;
     case 12:
         d += u.p32[2];
         c += u.p64[0];
         break;
     case 11:
         d += ((uint64_t)u.p8[10]) << 16;
+        FOLLY_FALLTHROUGH;
     case 10:
         d += ((uint64_t)u.p8[9]) << 8;
+        FOLLY_FALLTHROUGH;
     case 9:
         d += (uint64_t)u.p8[8];
+        FOLLY_FALLTHROUGH;
     case 8:
         c += u.p64[0];
         break;
     case 7:
         c += ((uint64_t)u.p8[6]) << 48;
+        FOLLY_FALLTHROUGH;
     case 6:
         c += ((uint64_t)u.p8[5]) << 40;
+        FOLLY_FALLTHROUGH;
     case 5:
         c += ((uint64_t)u.p8[4]) << 32;
+        FOLLY_FALLTHROUGH;
     case 4:
         c += u.p32[0];
         break;
     case 3:
         c += ((uint64_t)u.p8[2]) << 16;
+        FOLLY_FALLTHROUGH;
     case 2:
         c += ((uint64_t)u.p8[1]) << 8;
+        FOLLY_FALLTHROUGH;
     case 1:
         c += (uint64_t)u.p8[0];
         break;

diff --git a/folly/experimental/io/HugePages.cpp b/folly/experimental/io/HugePages.cpp
index f94b818b2aa0a94500fe7a35786377fed29f5b1a..ad15d3597f3c41f262ef068a546447c45b14a851 100644 (file)
--- a/folly/experimental/io/HugePages.cpp
+++ b/folly/experimental/io/HugePages.cpp
@@ -30,6 +30,7 @@
 #include <boost/regex.hpp>
 
 #include <folly/Conv.h>
+#include <folly/CppAttributes.h>
 #include <folly/Format.h>
 #include <folly/Range.h>
 #include <folly/String.h>
@@ -99,9 +100,9 @@ size_t parsePageSizeValue(StringPiece value) {
   StringPiece numStr(value.data() + match.position(1), size_t(match.length(1)));
   size_t size = to<size_t>(numStr);
   switch (c) {
-  case 't': size *= 1024;
-  case 'g': size *= 1024;
-  case 'm': size *= 1024;
+  case 't': size *= 1024; FOLLY_FALLTHROUGH;
+  case 'g': size *= 1024; FOLLY_FALLTHROUGH;
+  case 'm': size *= 1024; FOLLY_FALLTHROUGH;
   case 'k': size *= 1024;
   }
   return size;