Check for self-assignment in move assignment

Summary:
Check for self-assignment in move assignment. Otherwise
Optional<Neko> cat = whatever;
cat = std::move(cat);
cat.hasValue(); // always returns false

Test Plan: fbmake runtests

Reviewed By: tjackson@fb.com

FB internal diff: D1440633

diff --git a/folly/Optional.h b/folly/Optional.h
index 701d744e9ad4ff16928afc2aea6c8962e71ef60d..eb8de160c8903d47bda5757c4e28b783bd402ae1 100644 (file)
--- a/folly/Optional.h
+++ b/folly/Optional.h
@@ -136,11 +136,13 @@ class Optional {
   }
 
   void assign(Optional&& src) {
-    if (src.hasValue()) {
-      assign(std::move(src.value()));
-      src.clear();
-    } else {
-      clear();
+    if (this != &src) {
+      if (src.hasValue()) {
+        assign(std::move(src.value()));
+        src.clear();
+      } else {
+        clear();
+      }
     }
   }
 

diff --git a/folly/test/OptionalTest.cpp b/folly/test/OptionalTest.cpp
index ff82abdcdc4e677870fe70f6cff596c6a8204b5e..79968d013f3b439b8607105414c9486b5497187b 100644 (file)
--- a/folly/test/OptionalTest.cpp
+++ b/folly/test/OptionalTest.cpp
@@ -379,6 +379,16 @@ TEST(Optional, MakeOptional) {
   EXPECT_EQ(**optIntPtr, 3);
 }
 
+TEST(Optional, SelfAssignment) {
+  Optional<int> a = 42;
+  a = a;
+  ASSERT_TRUE(a.hasValue() && a.value() == 42);
+
+  Optional<int> b = 23333333;
+  b = std::move(b);
+  ASSERT_TRUE(b.hasValue() && b.value() == 23333333);
+}
+
 class ContainsOptional {
  public:
   ContainsOptional() { }